Add FifoIO to expose fifos directly to client#1405
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 22, 2017
Merged
Add FifoIO to expose fifos directly to client#1405dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
mlaventure
reviewed
Aug 21, 2017
Contributor
There was a problem hiding this comment.
I'd rather not lose the test for Windows 👼
Member
Author
There was a problem hiding this comment.
There is not much of a difference with directIO for windows because of the pipe and Accept conn
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=======================================
Coverage 40.81% 40.81%
=======================================
Files 23 23
Lines 2923 2923
=======================================
Hits 1193 1193
Misses 1452 1452
Partials 278 278Continue to review full report at Codecov.
|
This allows clients an easier way to interact with the fifos for a container without having to use the built in copyIO functions when opening fifos. It's nothing that clients could not have already coded but since we use this type of functionality in the tests it makes sense to add an implementation here. Signed-off-by: Michael Crosby <[email protected]>
Member
Author
|
@mlaventure i think we should review and merge this to fix the issues we are seeing in PRs with the attach tests. I have it on my todo list to reenable this for windows |
Member
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
reload cni network config if has fs change events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows clients an easier way to interact with the fifos for a
container without having to use the built in copyIO functions when
opening fifos.
It's nothing that clients could not have already coded but since we use
this type of functionality in the tests it makes sense to add an
implementation here.
Fixes #1402
Signed-off-by: Michael Crosby [email protected]