Skip to content

Supplement Building documentation for Docker for Mac users.#1372

Merged
estesp merged 1 commit intocontainerd:masterfrom
jessvalarezo:d4m-gettingstarted
Aug 17, 2017
Merged

Supplement Building documentation for Docker for Mac users.#1372
estesp merged 1 commit intocontainerd:masterfrom
jessvalarezo:d4m-gettingstarted

Conversation

@jessvalarezo
Copy link
Copy Markdown
Contributor

When building containerd on my Docker for Mac I didn't realize I needed runc to fully utilize the ctr tool or client package. Here are additional instructions to hopefully help the next Docker for Mac developer.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 16, 2017

Codecov Report

Merging #1372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   36.31%   36.31%           
=======================================
  Files          23       23           
  Lines        2897     2897           
=======================================
  Hits         1052     1052           
  Misses       1608     1608           
  Partials      237      237

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89daacf...d8abb61. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Comment thread BUILDING.md Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conatinerd to containerd

@stevvooe
Copy link
Copy Markdown
Member

LGTM

(fix the typo)

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ed1c404 into containerd:master Aug 17, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants