Update hcsshim to 0.15.0-rc.2#13652
Closed
cpuguy83 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Brian Goff <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the vendored Windows shim dependency stack by bumping github.com/Microsoft/hcsshim to v0.15.0-rc.2, pulling in associated dependency updates (notably github.com/cilium/ebpf, github.com/opencontainers/selinux, cyphar.com/go-pathrs, and golang.org/x/net) and regenerating vendor contents accordingly.
Changes:
- Bump
github.com/Microsoft/hcsshimtov0.15.0-rc.2and refresh vendored sources. - Update vendored
github.com/cilium/ebpftov0.17.3(new mmap-backed variable/memory support, refactors, new internal packages). - Update vendored
github.com/opencontainers/selinuxtov1.15.0andcyphar.com/go-pathrstov0.2.4, plus minor vendor housekeeping.
Reviewed changes
Copilot reviewed 1 out of 157 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bumps hcsshim and several indirect dependencies; removes x/exp indirect. |
| vendor/modules.txt | Updates vendored module versions and package lists. |
| vendor/golang.org/x/net/http2/transport_wrap.go | Vendor update adjusting HTTP/2 transport wrapping behavior (go1.27 build). |
| vendor/golang.org/x/net/http2/server_wrap.go | Vendor update ensuring ALPN protos are registered (go1.27 build). |
| vendor/golang.org/x/exp/PATENTS | Removes vendored x/exp patent grant text (module no longer vendored). |
| vendor/golang.org/x/exp/LICENSE | Removes vendored x/exp license text (module no longer vendored). |
| vendor/golang.org/x/exp/constraints/constraints.go | Removes vendored x/exp constraints package (replaced upstream). |
| vendor/github.com/opencontainers/selinux/pkg/pwalkdir/pwalkdir.go | Vendor update (modern Go build handling / loop construct). |
| vendor/github.com/opencontainers/selinux/go-selinux/selinux.go | Vendor update: new APIs, deprecations, and SELinux label helpers. |
| vendor/github.com/opencontainers/selinux/go-selinux/selinux_stub.go | Vendor update: stub parity for new SELinux APIs and signatures. |
| vendor/github.com/opencontainers/selinux/go-selinux/label/label_stub.go | Vendor update: build tag cleanup. |
| vendor/github.com/opencontainers/selinux/go-selinux/label/label_linux.go | Vendor update: label option parsing and reservation behavior. |
| vendor/github.com/Microsoft/hcsshim/README.md | Vendor update: documentation links and detailed shim v2 overview. |
| vendor/github.com/Microsoft/hcsshim/Protobuild.toml | Vendor update: spelling fix and updated protobuf prefix mapping. |
| vendor/github.com/Microsoft/hcsshim/internal/winapi/zsyscall_windows.go | Vendor update: adds CPU affinity/group-related syscall wrappers. |
| vendor/github.com/Microsoft/hcsshim/internal/winapi/jobobject.go | Vendor update: introduces GROUP_AFFINITY struct mirror. |
| vendor/github.com/Microsoft/hcsshim/internal/winapi/cpuaffinity.go | Vendor update: adds mksyscall declarations for CPU affinity APIs. |
| vendor/github.com/Microsoft/hcsshim/internal/winapi/cimwriter/cimwriter.go | Vendor update: enhanced DLL load logging incl. file version. |
| vendor/github.com/Microsoft/hcsshim/internal/wclayer/legacy.go | Vendor update: ensures handles are closed on reset error paths. |
| vendor/github.com/Microsoft/hcsshim/internal/wclayer/importlayer.go | Vendor update: cleans temp import dir when writer init fails. |
| vendor/github.com/Microsoft/hcsshim/internal/wclayer/expandscratchsize.go | Vendor update: uses go-winio/vhd AttachVirtualDisk helper. |
| vendor/github.com/Microsoft/hcsshim/internal/logfields/fields.go | Vendor update: expands structured logging field keys. |
| vendor/github.com/Microsoft/hcsshim/internal/log/scrub.go | Vendor update: enable scrubbing by default; adds CreateOptions scrubber. |
| vendor/github.com/Microsoft/hcsshim/internal/log/hook.go | Vendor update: small encoding switch-case adjustment. |
| vendor/github.com/Microsoft/hcsshim/internal/jobobject/limits.go | Vendor update: adds ctx parameter; supports multi-group CPU affinity. |
| vendor/github.com/Microsoft/hcsshim/internal/jobobject/jobobject.go | Vendor update: JobLimits extended with GroupAffinities. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/system.go | Vendor update: refactors silo opening; adds CPU group affinity + PropertiesV3. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/virtual_pci_device.go | Vendor update: formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/virtual_machine.go | Vendor update: adds migration options and ResourcePartitionId. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/virtual_machine_processor.go | Vendor update: formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/virtual_machine_memory.go | Vendor update: formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/topology.go | Vendor update: formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/storage.go | Vendor update: adds PrivilegedContainerRootPath. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/storage_stats.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/statistics.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/silo_properties.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/property_query.go | Vendor update: adds Queries map for property query. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/properties.go | Vendor update: adds PropertyResponses / PropertyResponse type. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/processor.go | Vendor update: schema API version comment update. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/processor_stats.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/process_details.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/plan9_share.go | Vendor update: replaces ad-hoc flags with Plan9ShareFlags type. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/plan9_share_flags.go | Vendor update: introduces typed Plan9 share flags constants. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/pause_options.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/pause_notification.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/numa_setting.go | Vendor update: formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/migration.go | Vendor update: adds schema types for live migration workflow. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/memory_stats.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/hv_socket_system_config.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/hv_socket_address.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/hv_socket_2.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/guest_connection_info.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/container.go | Vendor update: adds IsolationType + HostProcess constant. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/container_memory_information.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema2/com_port.go | Vendor update: comment formatting cleanup. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/schema1/schema1.go | Vendor update: adds HostProcessContainerSupported capability. |
| vendor/github.com/Microsoft/hcsshim/internal/hcs/process.go | Vendor update: implements Process.MigrationState() (zero value for HCS). |
| vendor/github.com/Microsoft/hcsshim/internal/cow/cow.go | Vendor update: introduces MigrationState + container CPU group affinity API. |
| vendor/github.com/Microsoft/hcsshim/hcn/hcnpolicy.go | Vendor update: fixes JSON struct tags for policy settings. |
| vendor/github.com/Microsoft/hcsshim/hcn/hcnnamespace.go | Vendor update: fixes JSON struct tags for namespace resource structs. |
| vendor/github.com/Microsoft/hcsshim/cmd/containerd-shim-runhcs-v1/stats/stats.pb.go | Vendor update: protoc-gen-go version bump in generated code. |
| vendor/github.com/Microsoft/hcsshim/cmd/containerd-shim-runhcs-v1/options/runhcs.proto | Vendor update: makes scrub_logs optional w/ clarified default semantics. |
| vendor/github.com/Microsoft/hcsshim/cmd/containerd-shim-runhcs-v1/options/runhcs.pb.go | Vendor update: reflects optional scrub_logs in generated Go. |
| vendor/github.com/Microsoft/hcsshim/.gitignore | Vendor update: ignore additional build artifacts (manifest/rust target). |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.go | Vendor update: avoids downgrade fallback after openat2 errors; tracks seccomp disabling. |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.go | Vendor update: closes old file on retry replacement. |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.go | Vendor update: prevents downgrade attack via unconditional fallback. |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_atomic_unsupported.go | Vendor update: adds atomic Bool shim for older Go on linux. |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_atomic_go119.go | Vendor update: uses atomic.Bool alias when available. |
| vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.go | Vendor update: makes Openat2 overridable for tests. |
| vendor/cyphar.com/go-pathrs/utils_linux.go | Vendor update: copyright / header maintenance. |
| vendor/cyphar.com/go-pathrs/root_linux.go | Vendor update: doc comment and reference cleanup. |
| vendor/cyphar.com/go-pathrs/procfs/procfs_linux.go | Vendor update: pid range check + conversion handling. |
| vendor/cyphar.com/go-pathrs/internal/libpathrs/libpathrs_linux.go | Vendor update: use C.size_t for buffer length in cgo calls. |
| vendor/cyphar.com/go-pathrs/internal/libpathrs/error_unix.go | Vendor update: copyright / header maintenance. |
| vendor/cyphar.com/go-pathrs/internal/fdutils/fd_linux.go | Vendor update: copyright / header maintenance. |
| vendor/cyphar.com/go-pathrs/handle_linux.go | Vendor update: doc comment fixes and clarification. |
| vendor/cyphar.com/go-pathrs/doc.go | Vendor update: copyright / header maintenance. |
| vendor/cyphar.com/go-pathrs/.golangci.yml | Vendor update: copyright / header maintenance. |
| vendor/github.com/cilium/ebpf/variable.go | Vendor update: adds global variable (datasec) manipulation APIs. |
| vendor/github.com/cilium/ebpf/types.go | Vendor update: new MapTypes and map type capability helpers; sys flag use. |
| vendor/github.com/cilium/ebpf/types_string.go | Vendor update: regenerated stringer output for MapType changes. |
| vendor/github.com/cilium/ebpf/syscalls.go | Vendor update: feature test API changes; internal/linux split usage. |
| vendor/github.com/cilium/ebpf/README.md | Vendor update: docs include new pin package reference. |
| vendor/github.com/cilium/ebpf/netlify.toml | Vendor update: pins docs build python version. |
| vendor/github.com/cilium/ebpf/memory.go | Vendor update: introduces Memory mmap abstraction (also adds Variable direct access). |
| vendor/github.com/cilium/ebpf/Makefile | Vendor update: testdata targets changes and container tty flag. |
| vendor/github.com/cilium/ebpf/linker.go | Vendor update: adds ksym reference resolution and refactors linking. |
| vendor/github.com/cilium/ebpf/link/uprobe.go | Vendor update: feature test signature change + error handling tweaks. |
| vendor/github.com/cilium/ebpf/link/uprobe_multi.go | Vendor update: uses sys flags; improves EINVAL error message; Update unsupported. |
| vendor/github.com/cilium/ebpf/link/tracing.go | Vendor update: Update is explicitly unsupported. |
| vendor/github.com/cilium/ebpf/link/syscalls.go | Vendor update: feature test signature change. |
| vendor/github.com/cilium/ebpf/link/perf_event.go | Vendor update: feature test signature change; Update unsupported. |
| vendor/github.com/cilium/ebpf/link/netfilter.go | Vendor update: Update unsupported. |
| vendor/github.com/cilium/ebpf/link/link.go | Vendor update: typed ObjGet for pinned links and uses sys pin/unpin. |
| vendor/github.com/cilium/ebpf/link/kprobe.go | Vendor update: internal/linux platform prefix use + kernel behavior notes. |
| vendor/github.com/cilium/ebpf/link/kprobe_multi.go | Vendor update: adds session mode support and feature probing. |
| vendor/github.com/cilium/ebpf/internal/version.go | Vendor update: moves kernel version detection into internal/linux. |
| vendor/github.com/cilium/ebpf/internal/unix/types_other.go | Vendor update: refactors non-linux compatibility and errno handling. |
| vendor/github.com/cilium/ebpf/internal/unix/types_linux.go | Vendor update: refactors errno constants and adds Auxv. |
| vendor/github.com/cilium/ebpf/internal/unix/strings_windows.go | Vendor update: adds windows BytePtrFromString / ByteSliceToString shims. |
| vendor/github.com/cilium/ebpf/internal/unix/strings_other.go | Vendor update: adds non-linux/non-windows string helpers. |
| vendor/github.com/cilium/ebpf/internal/unix/error.go | Vendor update: centralized errNonLinux wrapper. |
| vendor/github.com/cilium/ebpf/internal/unix/errno_windows.go | Vendor update: defines Windows errno shim and Errno type. |
| vendor/github.com/cilium/ebpf/internal/unix/errno_string_windows.go | Vendor update: stringer output for windows Errno. |
| vendor/github.com/cilium/ebpf/internal/unix/errno_other.go | Vendor update: defines errno constants on non-linux/non-windows. |
| vendor/github.com/cilium/ebpf/internal/unix/errno_linux.go | Vendor update: defines errno constants on linux. |
| vendor/github.com/cilium/ebpf/internal/tracefs/kprobe.go | Vendor update: linux FSType lookup; better EINVAL messaging. |
| vendor/github.com/cilium/ebpf/internal/testutils/fdtrace/main.go | Vendor update: adds fdtrace TestMain helper. |
| vendor/github.com/cilium/ebpf/internal/testutils/fdtrace/fd_trace.go | Vendor update: adds fd leak tracing utilities. |
| vendor/github.com/cilium/ebpf/internal/sysenc/buffer.go | Vendor update: exposes Bytes() and avoids unsafeBytes usage. |
| vendor/github.com/cilium/ebpf/internal/sys/syscall.go | Vendor update: moves constants and error wrapping to unix.Errno. |
| vendor/github.com/cilium/ebpf/internal/sys/ptr.go | Vendor update: generic slice pointer helper. |
| vendor/github.com/cilium/ebpf/internal/sys/pinning.go | Vendor update: sys package pinning helpers w/ linux.FSType checks. |
| vendor/github.com/cilium/ebpf/internal/sys/fd.go | Vendor update: fd tracing integration and typed ObjGet helper. |
| vendor/github.com/cilium/ebpf/internal/math.go | Vendor update: drops x/exp constraints; adds local Integer constraint + helpers. |
| vendor/github.com/cilium/ebpf/internal/linux/version.go | Vendor update: linux-only kernel version helpers. |
| vendor/github.com/cilium/ebpf/internal/linux/vdso.go | Vendor update: moves into linux package and uses internal helpers. |
| vendor/github.com/cilium/ebpf/internal/linux/statfs.go | Vendor update: moves into linux package. |
| vendor/github.com/cilium/ebpf/internal/linux/platform.go | Vendor update: moves into linux package. |
| vendor/github.com/cilium/ebpf/internal/linux/kconfig.go | Vendor update: adds kconfig discovery helper. |
| vendor/github.com/cilium/ebpf/internal/linux/doc.go | Vendor update: package doc for linux helpers. |
| vendor/github.com/cilium/ebpf/internal/linux/auxv.go | Vendor update: reads auxv via unix.Auxv instead of linkname. |
| vendor/github.com/cilium/ebpf/internal/kconfig/kconfig.go | Vendor update: parser cleanup and tristate writing fix. |
| vendor/github.com/cilium/ebpf/internal/kallsyms/reader.go | Vendor update: adds kallsyms word/line scanner. |
| vendor/github.com/cilium/ebpf/internal/kallsyms/cache.go | Vendor update: adds simple sync.Map-based cache helper. |
| vendor/github.com/cilium/ebpf/internal/goos.go | Vendor update: introduces internal.OnLinux constant. |
| vendor/github.com/cilium/ebpf/internal/feature.go | Vendor update: NewFeatureTest signature change and OS-aware support errors. |
| vendor/github.com/cilium/ebpf/internal/errors.go | Vendor update: removes deprecated VerifierError.Truncated field. |
| vendor/github.com/cilium/ebpf/elf_sections.go | Vendor update: adds kprobe.session and sk_skb/verdict section defs. |
| vendor/github.com/cilium/ebpf/CODEOWNERS | Vendor update: adds docs ownership entry. |
| vendor/github.com/cilium/ebpf/btf/workarounds.go | Vendor update: TypeTag rename and related handling. |
| vendor/github.com/cilium/ebpf/btf/traversal.go | Vendor update: decl tag traversal and tag flattening changes. |
| vendor/github.com/cilium/ebpf/btf/marshal.go | Vendor update: decl/type tag compatibility options and encoder refactors. |
| vendor/github.com/cilium/ebpf/btf/kernel.go | Vendor update: uses linux.KernelRelease and removes kallsyms flush coupling. |
| vendor/github.com/cilium/ebpf/btf/format.go | Vendor update: formatting support for Var. |
| vendor/github.com/cilium/ebpf/btf/feature.go | Vendor update: adds decl/type tag feature probes; updates feature test API. |
| vendor/github.com/cilium/ebpf/btf/btf.go | Vendor update: iterator skips declTags; .ksyms Datasec now supports Var(Void). |
| vendor/github.com/cilium/ebpf/btf/btf_types.go | Vendor update: documents kindTypeTag version. |
| vendor/github.com/cilium/ebpf/attachtype_string.go | Vendor update: regenerated stringer output for new attach type. |
| vendor/github.com/cilium/ebpf/asm/instruction.go | Vendor update: uses sys.BPF_TAG_SIZE constant. |
| vendor/github.com/cilium/ebpf/asm/func.go | Vendor update: removes BuiltinFunc.Max and maxBuiltinFunc sentinel. |
| vendor/github.com/cilium/ebpf/.golangci.yaml | Vendor update: adds depguard rule preventing direct x/sys/unix use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
thaJeztah
reviewed
Jun 23, 2026
| # github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6 | ||
| ## explicit; go 1.20 | ||
| github.com/AdaLogics/go-fuzz-headers | ||
| # github.com/Microsoft/go-winio v0.6.3-0.20251027160822-ad3df93bed29 |
Member
There was a problem hiding this comment.
Reminds me, would also be nice to have a new tag for go-winio; perhaps with;
- go.mod: raise minimum go version to go1.24 and use tools directive microsoft/go-winio#348
- ci: update actions and golangci-lint, and fix linting microsoft/go-winio#349
And I know a colleague is looking for;
Member
|
Needs a rebase @cpuguy83 😢
|
This was referenced Jun 30, 2026
github-project-automation
Bot
moved this from Needs Triage
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full diff https://github.com/microsoft/hcsshim/compare/v0.15.0-rc.1..v0.15.0-rc.2