erofs: align default mkfs block size across platforms#13624
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes mkfs.erofs invocation so that, unless the caller explicitly provides a -b... option, EROFS images are created with a 4K block size on all platforms to improve cross-platform mount compatibility (e.g., across differing host page sizes).
Changes:
- Remove the darwin-only gating so the default EROFS block size logic applies on all platforms.
- Keep respecting caller-supplied
-boptions while defaulting to-b4096when absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Force a 4K block size on all platforms rather than only on darwin. An explicit caller-supplied -b is still respected. Signed-off-by: Chris Crone <[email protected]>
54f32de to
773d351
Compare
hsiangkao
left a comment
hsiangkao
left a comment
There was a problem hiding this comment.
hi @chris-crone , looks good to me, but if we consider virtio-pmem passthough images into guests later, it needs strict page_size == block_size in order to enable dax and mmap dax pages (but yes, anyway, we could reconsider the strategy later).
also I will support large block size feature on the kernel side (already on my todo list), so that 16k block size can be mountable on 4k page guest kernels as well.
Thanks for the quick review @hsiangkao! Yes, we'll need to iterate on this as we add more functionality. Happy to help with that where needed. |
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
dmcgowan
added
the
cherry-picked/2.3.x
|
/cherry-pick release/2.3 |
|
@dmcgowan: new pull request created: #13632 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Force a 4K block size on all platforms rather than only on darwin. An explicit caller-supplied
-bis still respected.