[release/2.1] backport: sandbox: forward Create fields, fix event topics#13272
Merged
Conversation
The gRPC sandbox controller service only forwarded the `options` field
when calling the local controller. The `netns_path`, `rootfs`, and
`annotations` fields were silently dropped, causing clients using the
gRPC proxy path to receive incomplete sandbox configurations.
Event topics were missing the leading `/` prefix ("sandboxes/create"
instead of "/sandboxes/create"), causing the event exchange to reject
the publish and return an error to the caller.
Add unit tests for the controller service that exercise all RPC
methods.
Signed-off-by: William Myers <[email protected]>
(cherry picked from commit 557c54b)
Signed-off-by: Phil Estes <[email protected]>
Member
Author
|
Backported from #13260 |
mxpv
approved these changes
Apr 23, 2026
fuweid
approved these changes
Apr 24, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gRPC sandbox controller service only forwarded the
optionsfield when calling the local controller. Thenetns_path,rootfs, andannotationsfields were silently dropped, causing clients using the gRPC proxy path to receive incomplete sandbox configurations.Event topics were missing the leading
/prefix ("sandboxes/create" instead of "/sandboxes/create"), causing the event exchange to reject the publish and return an error to the caller.Add unit tests for the controller service that exercise all RPC methods.
(cherry picked from commit 557c54b)