Parameterize K8s version in node-e2e workflow#13234
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable-workflow input to allow parameterizing which Kubernetes branch/tag the node E2E workflow checks out, enabling compatibility testing against specific Kubernetes release branches.
Changes:
- Introduces a
workflow_callinput for selecting the Kubernetes ref (branch/tag). - Uses the new input to set
actions/checkoutreffor the Kubernetes repository.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dosubot
Bot
added
the
github_actions
Add inputs to workflow_call in node-e2e.yml to allow specifying Kubernetes branch or tag to test against. Update checkout step to use this input, defaulting to master. This enables testing containerd against specific Kubernetes release branches, which is required for verifying compatibility with extended support windows for Kubernetes distros that require them. Signed-off-by: Chris Henzie <[email protected]> Assisted-by: Antigravity
chrishenzie
force-pushed
the
parameterize-k8s-version
branch
from
April 14, 2026 16:32
f5f7270 to
270916a
Compare
thaJeztah
reviewed
Apr 14, 2026
| @@ -41,6 +46,7 @@ jobs: | |||
| with: | |||
| repository: kubernetes/kubernetes | |||
Member
There was a problem hiding this comment.
Repository doesn't require parameterization? (considering if there'd be cases where a temporary fork must be tested against)
Member
There was a problem hiding this comment.
YAGNI? We have a use-case for parameterized Kubernetes versions right now for the release/2.0 and release/1.7 branches, but not for parameterized repos.
samuelkarp
approved these changes
Apr 14, 2026
fuweid
approved these changes
Apr 17, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 17, 2026
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add inputs to workflow_call in node-e2e.yml to allow specifying Kubernetes branch or tag to test against. Update checkout step to use this input, defaulting to master.
This enables testing containerd against specific Kubernetes release branches, which is required for verifying compatibility with extended support windows for Kubernetes distros that require them.
Assisted-by: Antigravity