update github.com/moby/spdystream v0.5.1#13215
Merged
samuelkarp merged 1 commit intocontainerd:mainfrom Apr 13, 2026
Merged
Conversation
Signed-off-by: Samuel Karp <[email protected]>
dims
approved these changes
Apr 13, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
dmcgowan
approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vendored github.com/moby/spdystream dependency to v0.5.1, bringing in upstream changes around stricter SPDY frame length/header parsing limits and new option hooks for configuring those limits.
Changes:
- Bump
github.com/moby/spdystreamfrom v0.5.0 to v0.5.1 (go.mod/go.sum/vendor/modules.txt). - Add configurable framer parsing limits (new
FramerOption+NewFramerWithOptions) and enforce additional frame/header size checks. - Update vendored notices/licenses for the
spdy/derived code (adds BSD LICENSE + PATENTS; updates NOTICE).
Reviewed changes
Copilot reviewed 1 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt | Updates vendored module version reference to v0.5.1. |
| go.mod | Bumps github.com/moby/spdystream requirement to v0.5.1. |
| go.sum | Updates checksums for github.com/moby/spdystream v0.5.1. |
| vendor/github.com/moby/spdystream/spdy/types.go | Adds framer option plumbing and default parsing limit constants. |
| vendor/github.com/moby/spdystream/spdy/options.go | Introduces FramerOption and limit-setting helpers. |
| vendor/github.com/moby/spdystream/spdy/read.go | Adds control-frame payload limiting and header count/field-size limits. |
| vendor/github.com/moby/spdystream/spdy/write.go | Adds payload length validation when serializing frames/headers. |
| vendor/github.com/moby/spdystream/connection.go | Adds NewConnectionWithOptions and closes conn on invalid control frame. |
| vendor/github.com/moby/spdystream/NOTICE | Expands notice text to cover the spdy/ derived code and license locations. |
| vendor/github.com/moby/spdystream/spdy/LICENSE | Adds BSD 3-Clause license text for derived Go code. |
| vendor/github.com/moby/spdystream/spdy/PATENTS | Adds Go project patent grant. |
| vendor/github.com/moby/spdystream/spdy/dictionary.go | Removes Docker Apache header block from derived Go code file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Apr 13, 2026
chrishenzie
added
cherry-picked/1.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.