Skip to content

[release/2.2] update to go1.25.8, test go1.26.1#13010

Closed
k8s-infra-cherrypick-robot wants to merge 1 commit intocontainerd:release/2.2from
k8s-infra-cherrypick-robot:cherry-pick-12985-to-release/2.2
Closed

[release/2.2] update to go1.25.8, test go1.26.1#13010
k8s-infra-cherrypick-robot wants to merge 1 commit intocontainerd:release/2.2from
k8s-infra-cherrypick-robot:cherry-pick-12985-to-release/2.2

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #12985

/assign thaJeztah

go1.25.8 (released 2026-03-05) includes security fixes to the html/template,
net/url, and os packages, as well as bug fixes to the go command, the compiler,
and the os package. See the Go 1.25.8 milestone on our issue tracker for details.

- 1.25.8 https://github.com/golang/go/issues?q=milestone%3AGo1.25.8+label%3ACherryPickApproved
- diff: golang/go@go1.25.7...go1.25.8
- 1.26.1 https://github.com/golang/go/issues?q=milestone%3AGo1.26.1+label%3ACherryPickApproved
- diff: golang/go@go1.26.0...go1.26.1
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

Wait; why does it truncate the commit message? (and remove the DCO?)

@thaJeztah
Copy link
Copy Markdown
Member

closing in favor of #13011

@thaJeztah thaJeztah closed this Mar 11, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Pull Request Review Mar 11, 2026
@akhilerm
Copy link
Copy Markdown
Member

Wait; why does it truncate the commit message? (and remove the DCO?)

Because there is --- in the commit message which is used as delimiter by git am command to separate between commit message and actual diff. We face the same issue when using the cherry pick plugin on dependabot commits. Ref: dependabot/dependabot-core#13918, kubernetes-sigs/prow#380

@thaJeztah
Copy link
Copy Markdown
Member

OOOOOH! Yes, that makes sense; I got bit in the past by trying to use ## markdown-style headings, which of course are comments in the commit message, so sometimes use --- to somewhat organise my message, but didn't consider the other format 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/toolchain Build and Release Toolchain size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants