Skip to content

ci: modprobe xt_comment on almalinux#12950

Merged
mxpv merged 1 commit intocontainerd:mainfrom
ningmingxiao:fix_ci_iptables
Mar 2, 2026
Merged

ci: modprobe xt_comment on almalinux#12950
mxpv merged 1 commit intocontainerd:mainfrom
ningmingxiao:fix_ci_iptables

Conversation

@ningmingxiao
Copy link
Copy Markdown
Contributor

@ningmingxiao ningmingxiao commented Feb 28, 2026 •
edited
Loading

fix #12953

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Feb 28, 2026
@dosubot dosubot Bot added the area/toolchain Build and Release Toolchain label Feb 28, 2026
@ningmingxiao ningmingxiao force-pushed the fix_ci_iptables branch 3 times, most recently from 89a490c to c9b2e24 Compare February 28, 2026 11:02
@ningmingxiao ningmingxiao changed the title ci: install iptables on almalinux ci: modprobe xt_comment on almalinux Feb 28, 2026
AkihiroSuda
AkihiroSuda reviewed Feb 28, 2026
View reviewed changes
Comment thread Vagrantfile
strace \
kernel-modules-extra-$(uname -r) \
${INSTALL_PACKAGES}
modprobe xt_comment
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn't CI failing so far?

Copy link
Copy Markdown
Contributor Author

@ningmingxiao ningmingxiao Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what almalinux changes these days. but find xt_comment is needed.

@mxpv mxpv mentioned this pull request Mar 1, 2026
Closed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 2, 2026
@mxpv mxpv added this pull request to the merge queue Mar 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026
@mxpv mxpv added this pull request to the merge queue Mar 2, 2026
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Mar 2, 2026

/cherry-pick release/2.2
/cherry-pick release/2.1
/cherry-pick release/1.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Mar 2, 2026

@AkihiroSuda: once the present PR merges, I will cherry-pick it on top of release/1.7, release/2.1, release/2.2 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release/2.2
/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Merged via the queue into containerd:main with commit 62c0132 Mar 2, 2026
53 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Mar 2, 2026
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 2, 2026
Merged
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Mar 2, 2026

@AkihiroSuda: new pull request created: #12957

Details

In response to this:

/cherry-pick release/2.2
/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 2, 2026
Merged
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Mar 2, 2026

@AkihiroSuda: new pull request created: #12958

Details

In response to this:

/cherry-pick release/2.2
/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Mar 2, 2026

@AkihiroSuda: new pull request created: #12959

Details

In response to this:

/cherry-pick release/2.2
/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 2, 2026
Merged
@ningmingxiao ningmingxiao deleted the fix_ci_iptables branch March 2, 2026 20:24
@mark-liu mark-liu mentioned this pull request Mar 15, 2026
Open
@samuelkarp samuelkarp mentioned this pull request Apr 7, 2026
Merged
@chrishenzie chrishenzie added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/toolchain Build and Release Toolchain cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch size/XS

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestAdditionalGids failed on almalinux10

6 participants

@ningmingxiao @AkihiroSuda @k8s-infra-cherrypick-robot @mxpv @chrishenzie @k8s-ci-robot