ci: set fetch-depth for containerd to 0 for version parsing#12855
Merged
estesp merged 1 commit intocontainerd:mainfrom Feb 3, 2026
Merged
ci: set fetch-depth for containerd to 0 for version parsing#12855estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
image volume e2e tests in k/k uses containerd version to trigger tests for some features. ref: https://github.com/kubernetes/kubernetes/blob/bfafa32d90958a8fe7a2ce09ed553fdfef4edd98/test/e2e_node/image_volume.go#L64 The current CI builds have only the SHA as the version since the tags are not present. setting fetch-depth makes sure the tags are present and will be used while testing. Signed-off-by: Akhil Mohan <[email protected]>
dosubot
Bot
added
the
github_actions
Member
|
Could we also set |
dmcgowan
approved these changes
Feb 3, 2026
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
Should fix CI issue, we can test changing to a different option later
djdongjin
approved these changes
Feb 3, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
dims
approved these changes
Feb 3, 2026
samuelkarp
approved these changes
Feb 3, 2026
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
|
Thanks @akhilerm |
Member
Author
fetch-tags with shallow clone does not work currently. Its fixed in v6.0.2 which is currently not marked as latest release, when that bump is done, we can use fetch-tags in both containerd and k/k checkout. |
Member
Author
|
/cherry-pick release/2.2 |
|
@akhilerm: new pull request created: #12875 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
samuelkarp
added
the
cherry-picked/2.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image volume e2e tests in k/k uses containerd version to trigger tests for some features. ref: https://github.com/kubernetes/kubernetes/blob/bfafa32d90958a8fe7a2ce09ed553fdfef4edd98/test/e2e_node/image_volume.go#L64
The current CI builds have only the SHA as the version in the node e2e tests since the tags are not present. setting fetch-depth makes sure the tags are present and will be used while testing.
The issue occured now because as part of kubernetes/kubernetes#136530, the ImageVolume feature now started testing in the github actions e2e node tests.