Remove image service dependency from podsandbox controller#12849
Merged
mxpv merged 5 commits intocontainerd:mainfrom Feb 20, 2026
Merged
Remove image service dependency from podsandbox controller#12849mxpv merged 5 commits intocontainerd:mainfrom
mxpv merged 5 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
dmcgowan
approved these changes
Feb 19, 2026
dims
approved these changes
Feb 20, 2026
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the last significant dependency on internal CRI APIs, opening the path for migration down to the shim.
I've made several attempts to decouple the
Controllerfrom the rest of the CRI APIs, but it's challenging without major refactoring (see previous attempts: #7061). As a result, I've moved pause container pulling back to the CRI layer. Since almost every runtime today assumes pause containers anyway, this should not be a significant issue.If/when we come up with a different solution, we can deprecate and remove this. Additionally, we can make this conditional once #12786 lands.