cri: use mount manager when image has volumes#12847
Conversation
When a container image has a volumes attribute, currently the mount manager is not used here. This leads to issues with the EROFS snapshotter, notably that rwlayer.img is not present when the snapshotter is configured to create a writable block volume. This change implements mount manager as part of the image volumes processing, so that mount manager mounts are correctly processes before calling mount.All Fixes: containerd#12834 Signed-off-by: Champ-Goblem <[email protected]>
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
This is another area where we should reconsider the interface to use fs.FS rather than assuming the host can/should mount to perform this operation.
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
|
@containerd/committers (... could someone try again?..) |
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
|
/cherry-pick release/2.2 |
|
@hsiangkao: new pull request created: #12874 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hsiangkao
added
the
cherry-pick/2.2.x
|
/cherry-pick release/2.2 |
|
@hsiangkao: new pull request created: #13242 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fuweid
added
cherry-picked/2.2.x
7 participants
When a container image has a volumes attribute, currently the mount manager is not used here. This leads to issues with the EROFS snapshotter, notably that rwlayer.img is not present when the snapshotter is configured to create a writable block volume.
This change implements mount manager as part of the image volumes processing, so that mount manager mounts are correctly processes before calling mount.All
Fixes: #12834