ci: add build/test go1.26.0, drop go1.24 by akhilerm · Pull Request #12844 · containerd/containerd

akhilerm · 2026-02-01T17:05:12Z

add go1.26.0 into build and test matrix
drop go1.24
drop windows/arm builds
update golangci-lint to v2.9.0 for go1.26 support

dosubot · 2026-02-01T17:05:23Z

Related Documentation

No published documentation to review for changes on this repository.

^{How did I do? Any feedback?}

thaJeztah · 2026-02-11T13:16:48Z

Looks like CI settings need to be updated, because the windows/arm build was removed /cc @dmcgowan (not sure who all has permissions to change those);

thaJeztah

LGTM

we probably want to backport this to the release branches, now that go1.24 reached end of the line.

add go1.26.0 into test matrix and remove go1.24 Signed-off-by: Akhil Mohan <[email protected]>

go 1.26 removes support for windows/arm (NOT windows/arm64) ref: https://tip.golang.org/doc/go1.26#windows Signed-off-by: Akhil Mohan <[email protected]>

Signed-off-by: Akhil Mohan <[email protected]>

thaJeztah

LGTM

thaJeztah · 2026-02-18T12:19:36Z

/cherry-pick release/2.2 release/2.1 release/1.7

k8s-infra-cherrypick-robot · 2026-02-18T12:20:24Z

@thaJeztah: new pull request created: #12917

Details

In response to this:

/cherry-pick release/2.2 release/2.1 release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

akhilerm · 2026-02-19T05:57:53Z

/cherry-pick release/2.1
/cherry-pick release/1.7

k8s-infra-cherrypick-robot · 2026-02-19T05:58:29Z

@akhilerm: #12844 failed to apply on top of branch "release/1.7":

Applying: ci: build/test go1.26.0
Using index info to reconstruct a base tree...
A	.devcontainer/devcontainer.json
M	.github/workflows/api-release.yml
M	.github/workflows/ci.yml
M	.github/workflows/release/Dockerfile
M	Vagrantfile
M	contrib/Dockerfile.test
M	contrib/fuzz/oss_fuzz_build.sh
M	script/setup/prepare_env_windows.ps1
Falling back to patching base and 3-way merge...
Auto-merging script/setup/prepare_env_windows.ps1
Auto-merging contrib/fuzz/oss_fuzz_build.sh
Auto-merging contrib/Dockerfile.test
Auto-merging Vagrantfile
Auto-merging .github/workflows/release/Dockerfile
Auto-merging .github/workflows/ci.yml
Auto-merging .github/workflows/api-release.yml
CONFLICT (modify/delete): .devcontainer/devcontainer.json deleted in HEAD and modified in ci: build/test go1.26.0. Version ci: build/test go1.26.0 of .devcontainer/devcontainer.json left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 ci: build/test go1.26.0

Details

In response to this:

/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2026-02-19T05:59:03Z

@akhilerm: #12844 failed to apply on top of branch "release/2.1":

Applying: ci: build/test go1.26.0
Applying: remove windows/arm from cross build
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/ci.yml
Applying: update golangci-lint to v2.9.0 with go1.26 support
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/ci.yml
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0003 update golangci-lint to v2.9.0 with go1.26 support

Details

In response to this:

/cherry-pick release/2.1
/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

apurv15 · 2026-02-27T15:34:08Z

While windows/arm pipelines are removed here, should windows/arm64 (64-bit) be added instead?

thaJeztah · 2026-02-27T16:58:39Z

Yeah probably should be added; I'd expected it to already be there, but looks like it's not (not sure why not though; I know arm(64) support on Windows was still somewhat in development, so perhaps because of that?)

@apurv15 feel free to open a PR (at least for further discussion)

github-project-automation Bot added this to Pull Request Review Feb 1, 2026

github-project-automation Bot moved this to Needs Triage in Pull Request Review Feb 1, 2026

k8s-ci-robot added the size/XS label Feb 1, 2026

dosubot Bot added the github_actions Pull requests that update GitHub Actions code label Feb 1, 2026

akhilerm force-pushed the go-1.26 branch from 8d75081 to 1ef98cc Compare February 1, 2026 17:07

akhilerm changed the title ~~[DNM] ci: build/test go1.26-rc.2~~ [DNM] ci: build/test go1.26.0-rc.2 Feb 1, 2026

k8s-ci-robot added the needs-rebase label Feb 2, 2026

akhilerm force-pushed the go-1.26 branch from 1ef98cc to 7a1d865 Compare February 10, 2026 09:25

k8s-ci-robot removed the needs-rebase label Feb 10, 2026

akhilerm changed the title ~~[DNM] ci: build/test go1.26.0-rc.2~~ [DNM] ci: build/test go1.26.0-rc Feb 10, 2026

k8s-ci-robot added size/M and removed size/XS labels Feb 10, 2026

akhilerm force-pushed the go-1.26 branch from c984ea1 to a351cd1 Compare February 11, 2026 11:34

k8s-ci-robot added size/S and removed size/M labels Feb 11, 2026

akhilerm changed the title ~~[DNM] ci: build/test go1.26.0-rc~~ ci: add build/test go1.26.0, drop go1.24 Feb 11, 2026

akhilerm added the area/toolchain Build and Release Toolchain label Feb 11, 2026

thaJeztah approved these changes Feb 11, 2026

View reviewed changes

thaJeztah added cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch cherry-pick/2.2.x Change to be cherry picked to release/2.2 branch labels Feb 11, 2026

akhilerm added 3 commits February 12, 2026 09:03

ci: build/test go1.26.0

9a0c5f1

add go1.26.0 into test matrix and remove go1.24 Signed-off-by: Akhil Mohan <[email protected]>

remove windows/arm from cross build

e4320e6

go 1.26 removes support for windows/arm (NOT windows/arm64) ref: https://tip.golang.org/doc/go1.26#windows Signed-off-by: Akhil Mohan <[email protected]>

update golangci-lint to v2.9.0 with go1.26 support

1f84d27

Signed-off-by: Akhil Mohan <[email protected]>

akhilerm force-pushed the go-1.26 branch from 35e0b45 to 1f84d27 Compare February 12, 2026 03:33

akhilerm requested a review from thaJeztah February 12, 2026 03:34

thaJeztah reviewed Feb 12, 2026

View reviewed changes

Comment thread .github/actions/install-go/action.yml

thaJeztah approved these changes Feb 12, 2026

View reviewed changes

samuelkarp approved these changes Feb 12, 2026

View reviewed changes

samuelkarp added this pull request to the merge queue Feb 12, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026

estesp added this pull request to the merge queue Feb 12, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026

akhilerm moved this from Review In Progress to Merge on Green in Pull Request Review Feb 18, 2026

mxpv added this pull request to the merge queue Feb 18, 2026

Merged via the queue into containerd:main with commit 97c4540 Feb 18, 2026
94 of 96 checks passed

github-project-automation Bot moved this from Merge on Green to Done in Pull Request Review Feb 18, 2026

akhilerm deleted the go-1.26 branch February 18, 2026 05:30

k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2026

[release/2.2] ci: add build/test go1.26.0, drop go1.24 #12917

Merged

akhilerm added cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch and removed cherry-pick/2.2.x Change to be cherry picked to release/2.2 branch labels Feb 19, 2026

apurv15 mentioned this pull request Mar 4, 2026

Introduce Windows Arm64 build in CI workflow #12974

Merged

thaJeztah mentioned this pull request Mar 11, 2026

[release/2.1 backport] update to go1.25.8, test go1.26.1 #13013

Merged

1 task

This was referenced Apr 9, 2026

[release/2.0] update to Go 1.25.9, 1.26.2 #13199

Merged

[release/1.7] update to Go 1.25.9, 1.26.2 #13200

Merged

Conversation

akhilerm commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dosubot Bot commented Feb 1, 2026

Uh oh!

thaJeztah commented Feb 11, 2026

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thaJeztah commented Feb 18, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Feb 18, 2026

Uh oh!

akhilerm commented Feb 19, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Feb 19, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Feb 19, 2026

Uh oh!

apurv15 commented Feb 27, 2026

Uh oh!

thaJeztah commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

akhilerm commented Feb 1, 2026 •

edited

Loading