Skip to content

cri/podsandbox: reduce dependencies to internal CRI APIs#12773

Merged
mxpv merged 1 commit intocontainerd:mainfrom
mxpv:podsandbox
Jan 17, 2026
Merged

cri/podsandbox: reduce dependencies to internal CRI APIs#12773
mxpv merged 1 commit intocontainerd:mainfrom
mxpv:podsandbox

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Jan 10, 2026

Reduces podsandbox/ dependencies from internal CRI APIs.

This PR:

  • Removes RuntimeService service dependency. LoadOCISpec was never used for sadnbox containers.
  • Reduces ImageService dependencies. Fetches required info from the config instead of calling APIs.

This relies on CRI configuration injected during init time. This would be straightforward to handle in the runtime code.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Jan 10, 2026
@mxpv mxpv changed the title cri/podsandbox: reduce service interface dependencies cri/podsandbox: reduce dependencies to internal CRI APIs Jan 10, 2026
@mxpv mxpv added the area/cri Container Runtime Interface (CRI) label Jan 10, 2026
@mxpv mxpv marked this pull request as ready for review January 10, 2026 22:54
Comment thread internal/cri/server/podsandbox/controller.go
Comment thread internal/cri/server/podsandbox/helpers.go
@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Jan 17, 2026
@mxpv mxpv added this pull request to the merge queue Jan 17, 2026
Merged via the queue into containerd:main with commit fb80501 Jan 17, 2026
52 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) size/M

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants