Skip to content

Pass container user (uid, gids) to plugins#12769

Merged
mxpv merged 1 commit intocontainerd:mainfrom
klihub:devel/main/nri-input/container-user
Jan 13, 2026
Merged

Pass container user (uid, gids) to plugins#12769
mxpv merged 1 commit intocontainerd:mainfrom
klihub:devel/main/nri-input/container-user

Conversation

@klihub
Copy link
Copy Markdown
Member

@klihub klihub commented Jan 9, 2026

Implement missing support for passing any container user (uid, gids) as input to NRI plugins.

@klihub klihub requested review from mikebrow and samuelkarp January 9, 2026 17:31
@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Jan 9, 2026
@dosubot dosubot Bot added area/cri Container Runtime Interface (CRI) area/nri Node Resource Interface (NRI) labels Jan 9, 2026
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow force-pushed the devel/main/nri-input/container-user branch from 5b344f5 to a59c776 Compare January 9, 2026 21:20
@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Jan 9, 2026
@mxpv mxpv added this pull request to the merge queue Jan 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jan 9, 2026
@mxpv mxpv enabled auto-merge January 9, 2026 23:32
@klihub klihub force-pushed the devel/main/nri-input/container-user branch from a59c776 to eb9df8d Compare January 10, 2026 08:57
@klihub klihub force-pushed the devel/main/nri-input/container-user branch from eb9df8d to 6b71b3b Compare January 11, 2026 16:15
@mikebrow mikebrow force-pushed the devel/main/nri-input/container-user branch from 6b71b3b to 4fa5080 Compare January 12, 2026 15:12
@mxpv
Copy link
Copy Markdown
Member

mxpv commented Jan 12, 2026

Still has merge conflicts

@klihub klihub force-pushed the devel/main/nri-input/container-user branch from 4fa5080 to 80ebccd Compare January 13, 2026 07:28
@klihub
Copy link
Copy Markdown
Member Author

klihub commented Jan 13, 2026

Still has merge conflicts

Rebased on latest main/HEAD.

@mikebrow mikebrow force-pushed the devel/main/nri-input/container-user branch from 80ebccd to b0bd04b Compare January 13, 2026 13:59
@mxpv mxpv added this pull request to the merge queue Jan 13, 2026
Merged via the queue into containerd:main with commit 87a16b2 Jan 13, 2026
52 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jan 13, 2026
@klihub klihub deleted the devel/main/nri-input/container-user branch January 14, 2026 09:59
@tuminoid
Copy link
Copy Markdown

Thanks @klihub ! Looking forward to v2.3.0 and being able to drop some workarounds related to uid/gid passing.

@dmcgowan dmcgowan added impact/changelog and removed area/cri Container Runtime Interface (CRI) labels Mar 17, 2026
@dmcgowan dmcgowan changed the title cri,nri: pass container user (uid, gids) to plugins. Pass container user (uid, gids) to plugins Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nri Node Resource Interface (NRI) impact/changelog size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants