go.mod: remove exclude rules#12649
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Dec 9, 2025
Merged
Conversation
Commit 00a11e9 added these exclude rules as a temporary workaround until these transitive dependency versions would be gone; > downgrade go-difflib and go-spew to tagged releases > > These dependencies were updated to "master" in some modules we depend on, > but have no code-changes since their last release. Unfortunately, this also > causes a ripple effect, forcing all users of the containerd module to also > update these dependencies to an unrelease / un-tagged version. > > Both these dependencies will unlikely do a new release in the near future, > so exclude these versions so that we can downgrade to the current release. Commit fb8c01d updated the containerd/zfs module to v2.0.0, which was the remaining dependency using these untagged versions, so we can remove these exclude rules again. This reverts commit 00a11e9. Signed-off-by: Sebastiaan van Stijn <[email protected]>
austinvazquez
approved these changes
Dec 9, 2025
akhilerm
approved these changes
Dec 9, 2025
github-project-automation
Bot
moved this from Needs Reviewers
to Review In Progress
in Pull Request Review
AkihiroSuda
approved these changes
Dec 9, 2025
AkihiroSuda
added
cherry-pick/2.1.x
Member
Author
|
@AkihiroSuda for cherry pick; this will require both this one and #12641 to be cherry-picked (probably fine though) |
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Dec 10, 2025
AkihiroSuda
added
cherry-picked/2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
Commit 00a11e9 added these exclude rules as a temporary workaround until these transitive dependency versions would be gone;
Commit fb8c01d updated the containerd/zfs module to v2.0.0, which was the remaining dependency using these untagged versions, so we can remove these exclude rules again.
This reverts commit 00a11e9.