ci(release): set GO_VERSION in Dockerfile#12583
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Nov 27, 2025
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
810a75b to
0eac0ee
Compare
austinvazquez
approved these changes
Nov 27, 2025
dmcgowan
approved these changes
Nov 27, 2025
fuweid
approved these changes
Nov 27, 2025
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the release Dockerfile can't be built because
GO_VERSIONbuild-arg is not specified:It should have a default as stated by the
InvalidDefaultArgInFrombuild check: https://docs.docker.com/reference/build-checks/invalid-default-arg-in-from/Looking at the release workflow, the
GO_VERSIONis only used for building the Dockerfile so I think we can just move it to the Dockerfile directly.Also relates to docker/packaging#321 where we have a use case to retrieve go version from upstream projects using outline build request: docker/packaging#319 (comment)