Set annotations parameter in CreateSandbox request#12566
Merged
mxpv merged 1 commit intocontainerd:mainfrom Jan 5, 2026
Merged
Set annotations parameter in CreateSandbox request#12566mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
mxpv
approved these changes
Nov 25, 2025
fals
reviewed
Nov 30, 2025
| Rootfs: mount.ToProto(coptions.Rootfs), | ||
| Options: typeurl.MarshalProto(coptions.Options), | ||
| NetnsPath: coptions.NetNSPath, | ||
| Annotations: coptions.Annotations, |
There was a problem hiding this comment.
Don´t we have any test covering this? This looks like kind a regression
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
@fals Can you please help me regarding the next steps? Can you please suggest how can i make progress in this PR?
djdongjin
approved these changes
Dec 28, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
In the CreateSandbox request, which is part of the Sandbox Controller, we ignored the `Annotations` parameter which could have been set by the caller via `WithAnnotations` option. This commit rectifies the same and adds the Annotations parameter to the request. Signed-off-by: Harsh Rawat <[email protected]>
Contributor
Author
|
@mxpv @djdongjin Can any of you please merge the PR? |
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the CreateSandbox request, which is part of the Sandbox Controller, we ignored the
Annotationsparameter which could have been set by the caller viaWithAnnotationsoption.This PR rectifies the same and adds the Annotations parameter to the request.
Issue: #12565