Revert "Implement io.ReaderAt on docker fetch reader"#12529
Merged
mxpv merged 1 commit intocontainerd:mainfrom Nov 18, 2025
Merged
Revert "Implement io.ReaderAt on docker fetch reader"#12529mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
Member
|
DCO check is failing @cpuguy83 |
This reverts commit 4bf1705. This caused issues for downstream clients who were wrapping the type contingent on it implementing io.ReaderAt. Consequently this is causing headaches due to increased round trips with the remote. Meanwhile I only added this as a convenience for implementing content.Provider in the remote which can done even without the original change, just... less conveniently. In hindsight, this was just a bad change as it has a rather wide impact and the actual implementation isn't an optimized ReaderAt. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
revert_reader_at
branch
from
21fbfe6 to
3c9a0bd
Compare
Member
Author
|
Fixed. |
dmcgowan
approved these changes
Nov 18, 2025
dmcgowan
added
the
cherry-pick/2.2.x
mxpv
approved these changes
Nov 18, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
|
/cherry-pick release/2.2 |
|
@thaJeztah: new pull request created: #12542 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
austinvazquez
added
cherry-picked/2.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4bf1705.
This caused issues for downstream clients who were wrapping the type contingent on it implementing io.ReaderAt.
Consequently this is causing headaches due to increased round trips with the remote.
Meanwhile I only added this as a convenience for implementing content.Provider in the remote which can done even without the original change, just... less conveniently.
In hindsight, this was just a bad change as it has a rather wide impact and the actual implementation isn't an optimized ReaderAt.
Related to moby/buildkit#6366, moby/buildkit#6359