client: clarify and rename WithRootFS#1249
Merged
stevvooe merged 2 commits intocontainerd:masterfrom Jul 25, 2017
Merged
Conversation
dmcgowan
changed the title
WithRootFSWithRootFS
Clarify terminology around functions which use and create snapshots for containers. Signed-off-by: Derek McGowan <[email protected]>
Add WithRootFS for task creation Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
client-rename-with-rootfs
branch
from
96ff86d to
c7cc6ad
Compare
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
- Coverage 28.37% 28.24% -0.13%
==========================================
Files 28 28
Lines 2841 2854 +13
==========================================
Hits 806 806
- Misses 1888 1901 +13
Partials 147 147
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
With*statements related to RootFS to clarify when a snapshot is created. AddWithRootFSto create a new task given mounts directly.Closes #1244
Replaces #1212