-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[release/1.7] Update GHA images and bump Go 1.24.9; 1.25.3 #12471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.7] Update GHA images and bump Go 1.24.9; 1.25.3 #12471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports CI infrastructure updates to the release/1.7 branch, including GitHub Actions runner image updates and Go version bumps from 1.24.8 to 1.24.9 and 1.25.2 to 1.25.3.
- Updates Go version from 1.24.8 to 1.24.9 across all build and test configurations
- Updates GitHub Actions runner images from specific versions (ubuntu-24.04, macos-13, windows-2025/2022) to their latest equivalents
- Updates Go 1.25.2 to 1.25.3 in the test matrix
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| script/setup/prepare_env_windows.ps1 | Updates Go version for Windows environment setup |
| contrib/fuzz/oss_fuzz_build.sh | Updates Go download URL and tarball extraction for fuzzing builds |
| contrib/Dockerfile.test | Updates default Go version in test Dockerfile |
| Vagrantfile | Updates default Go version for Vagrant VM provisioning |
| .github/workflows/release.yml | Updates Go version and runner images for release workflow |
| .github/workflows/ci.yml | Updates Go versions in test matrix and runner images for CI workflow |
| .github/workflows/api-release.yml | Updates Go version for API release workflow |
| .github/actions/install-go/action.yml | Updates default Go version for reusable install action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Teeny-tiny optimizations:
BenchmarkSprintf-10 37735996 32.31 ns/op 0 B/op 0 allocs/op
BenchmarkItoa-10 591945836 2.031 ns/op 0 B/op 0 allocs/op
BenchmarkFormatUint-10 593701444 2.014 ns/op 0 B/op 0 allocs/op
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 44e2b26)
Signed-off-by: Austin Vazquez <[email protected]>
These tests were failing on my macOS; could be the precision issue (like on
Windows), or just because they're "too fast".
=== RUN TestSourceDateEpoch/WithoutSourceDateEpoch
epoch_test.go:51:
Error Trace: /Users/thajeztah/go/src/github.com/containerd/containerd/pkg/epoch/epoch_test.go:51
Error: Should be true
Test: TestSourceDateEpoch/WithoutSourceDateEpoch
Messages: now: 2023-06-23 11:47:09.93118 +0000 UTC, v: 2023-06-23 11:47:09.93118 +0000 UTC
This patch:
- updates the rightAfter utility to allow the timestamps to be "equal"
- updates the asserts to provide some details about the timestamps
- uses UTC for the value we're comparing to, to match the timestamps
that are generated.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 9924e56)
Signed-off-by: Austin Vazquez <[email protected]>
This introduces a ParseSourceDateEpoch function, which can be used to parse "SOURCE_DATE_EPOCH" values for situations where those values are not passed through an env-var (or the env-var has been read through other means). Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 8760b87) Signed-off-by: Austin Vazquez <[email protected]>
For jobs which do not require a version matrix, such as some testing runs, use the latest runner image. Pinning the images unnecessarily causes more work later on when deciding when to upgrade and may cause more issues when older images brownout. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit d553c40) Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]> (cherry picked from commit f72025d) Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]> (cherry picked from commit acbaa8a) Signed-off-by: Austin Vazquez <[email protected]>
c5a23f5 to
667409f
Compare
|
Needs #8732 for |
Backports a handful of CI updates to update GHA images for low risk jobs and Go version update.