[github-action] release - Empty allowedSignersFile#12304
Conversation
|
Hi @jaredledvina. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dosubot
Bot
added
the
github_actions
Update the release Github Action workflow to create an empty allowedSignersFile and configure git to use it. This prevents failures when tags are signed with an SSH based key. Without this configuration, `git tag -v` errors with: ``` Output: error: gpg.ssh.allowedSignersFile needs to be configured and exist for ssh signature verification ``` Signed-off-by: Jared Ledvina <[email protected]>
f0e34d4 to
09644bd
Compare
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
|
/cherry-pick release/2.1 |
|
@fuweid: new pull request created: #13517 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Howdy! Likely you don't hit this upstream and it looks like the tags are currently signed with GPG based keys. However, on forks if you try to push a tag, this action fails if the signature is signed with an SSH key. As such, I'm offering this change upstream so you all could support future SSH signed git tags too. I've tested this on our fork and it seems to work with tags signed using my
ed25519key & leaving theallowedSignersFilefile empty. Without this, the CI job fails with:If you're open to this change and willing to backport it to the 2.1 release branch, that'd be swell! Thanks for considering!