client: add root mounts to task info#1212
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 28.09% 28.01% -0.08%
==========================================
Files 28 28
Lines 2833 2841 +8
==========================================
Hits 796 796
- Misses 1888 1896 +8
Partials 149 149
Continue to review full report at Codecov.
|
|
|
||
| type TaskInfo struct { | ||
| Checkpoint *types.Descriptor | ||
| RootMounts []mount.Mount |
There was a problem hiding this comment.
Should we rename CreateTaskRequest.RootFS to RootFSMounts?
@AkihiroSuda How does this fit with the rootfs specification?
There was a problem hiding this comment.
Why not just call it RootFS like we do an other places?
There was a problem hiding this comment.
There might be some other changes that make that confusing. Especially since we've moved away from being mostly mount oriented.
|
@dmcgowan While I think this PR is good for alpha1, let's hold off and figure out the naming here. |
|
LGTM |
|
Closing in favor of #1249 |
…ons-bandwith-error Return actual error when fetching the bandwidth info from annotation fails
5 participants
Add root mounts to task info and allow using root mounts on new task when specified.