Use forked archive/tar package for go 1.8 regression#1210
Merged
stevvooe merged 1 commit intocontainerd:masterfrom Jul 19, 2017
Merged
Use forked archive/tar package for go 1.8 regression#1210stevvooe merged 1 commit intocontainerd:masterfrom
stevvooe merged 1 commit intocontainerd:masterfrom
Conversation
Use fork of archive/tar to carry changes to tar for all go versions. Signed-off-by: Derek McGowan <[email protected]>
Member
Author
|
This will require rebasing after #1208, related to previous failure |
Member
|
@dmcgowan Consider the possibility that we could just detect these tar headers and error out. The condition is that the UID/GID is greater than |
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
=======================================
Coverage 28.09% 28.09%
=======================================
Files 28 28
Lines 2833 2833
=======================================
Hits 796 796
Misses 1888 1888
Partials 149 149Continue to review full report at Codecov.
|
Member
|
LGTM Filed #1219 to put together a better strategy here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fork of archive/tar to carry changes to tar for all go versions.
Includes patch for go 1.8 regression in reading tars created by earlier versions of go. See golang/go#21005