Skip to content

Conversation

@klihub
Copy link
Member

@klihub klihub commented Jul 10, 2025

Set up NRI for producing otel trace spans.

Set up NRI for producing otel trace spans.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested a review from mikebrow July 10, 2025 18:42
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Jul 10, 2025
@dosubot dosubot bot added the area/nri Node Resource Interface (NRI) label Jul 10, 2025
@klihub
Copy link
Member Author

klihub commented Jul 11, 2025

@mikebrow How about this one ?

@klihub
Copy link
Member Author

klihub commented Jul 14, 2025

@mikebrow Could we get this one reviewed and merged ?

/cc @fuweid

@k8s-ci-robot k8s-ci-robot requested a review from fuweid July 14, 2025 12:27
@klihub klihub requested review from fuweid and removed request for fuweid July 14, 2025 12:27
Copy link
Contributor

@halaney halaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a nice improvement, I've tested with something similar and it works well for us.

@klihub klihub requested a review from samuelkarp July 17, 2025 14:07
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Jul 20, 2025
@mikebrow mikebrow added this pull request to the merge queue Jul 21, 2025
Merged via the queue into containerd:main with commit 6373c7b Jul 21, 2025
123 of 128 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Jul 21, 2025
@klihub klihub deleted the devel/enable-nri-otel-tracing branch July 24, 2025 16:14
@dmcgowan dmcgowan changed the title nri: enable otel traces in NRI. Enable otel traces in NRI Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nri Node Resource Interface (NRI) impact/changelog size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants