blockfile: Ensure required options are always set#12065
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Jul 8, 2025
Merged
Conversation
|
Hi @fidencio. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fidencio
force-pushed
the
topic/blockfile-ensure-loop-is-part-of-the-mount-options
branch
from
247f171 to
a7c7478
Compare
dmcgowan
reviewed
Jul 7, 2025
fidencio
force-pushed
the
topic/blockfile-ensure-loop-is-part-of-the-mount-options
branch
from
a7c7478 to
6408813
Compare
dmcgowan
approved these changes
Jul 7, 2025
Member
|
/ok-to-test |
When using blockfile snapshotter and passing specific filesystem mount options, the users may be caught by surprise by the fact that some options are required but not documented anywhere. The easiest way to solve this is by ensuring that the "loop" required option is always added to the mount options. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/blockfile-ensure-loop-is-part-of-the-mount-options
branch
from
6408813 to
e0d733c
Compare
djdongjin
approved these changes
Jul 7, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
Member
|
/retest |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
dcantah
approved these changes
Jul 8, 2025
AkihiroSuda
approved these changes
Jul 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…s-part-of-the-mount-options blockfile: Ensure required options are always set
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using blockfile snapshotter and passing specific filesystem mount options, the users may be caught by surprise by the fact that some options are required but not documented anywhere.
The easiest way to solve this is by ensuring that the "loop" required option is always added to the mount options.