Add mount manager #12063
Merged
Add mount manager #12063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dmcgowan
force-pushed
the
mount-manager
branch
from
1a46cb7 to
a3b875d
Compare
dmcgowan
force-pushed
the
mount-manager
branch
from
26cb8fd to
3b2dfd0
Compare
dmcgowan
force-pushed
the
mount-manager
branch
2 times, most recently
from
6657f4b to
4195276
Compare
dmcgowan
force-pushed
the
mount-manager
branch
5 times, most recently
from
1bc2cbb to
f71db6f
Compare
dmcgowan
force-pushed
the
mount-manager
branch
from
8c7b9c5 to
3e8da83
Compare
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Create separate package for snapshotter test in metadata package to prevent circular dependency. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Avoid keeping file descriptor open to directory which is getting removed. Update error handling and wrapping to provide more clarity around failures. Signed-off-by: Derek McGowan <[email protected]>
The autoclear may take a bit of time to clear out the file, check multiple times for the file to get removed before returning an error. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Allow task manager to fetch info on runtimes at startup. Use this info to configure whether the runtime allows formatted mounts. This info could also be used in the future to enforce policy such as requiring a pre-known set of runtimes or specific runtime properties. Signed-off-by: Derek McGowan <[email protected]>
Allow the mount manager to skip handling of custom types. Ensure that custom types are still working with formatted mounts. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
mount-manager
branch
from
68bdd86 to
17f22db
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 48 out of 58 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
core/mount/manager/manager.go:1
- The TODO comment 'IF has sync' is unclear and incomplete. It should be clarified to explain what condition should be checked or removed if no longer needed.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Let the runtime specify which custom mounts it will support Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
mount-manager
branch
from
17f22db to
c7b3114
Compare
fuweid
approved these changes
Oct 3, 2025
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
Overall, LGTM
The change is huge. We need more e2e test for this in the follow-up, especially detecting leaky resources.
|
|
||
| // metadata_test is used to test the metadata snapshotter implementations | ||
| // against the snapshotter test suite. | ||
| package metadata_test |
Member
There was a problem hiding this comment.
since it's external package, maybe we can put this test in native plugin? it's not a blocker
github-project-automation
bot
moved this from Needs Reviewers
to Review In Progress
in Pull Request Review
github-project-automation
bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Oct 24, 2025
This was referenced Nov 5, 2025
wareagle461
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #11303
Depends on #12025mergedWIP Items:
Update implementation and testingcompleteMoving runtime implementation down to the task managercompletePassing runtime name tocompleteMore complete documentationcomplete