erofs-differ: fix filesystem UUID for tar-converted layers#12046
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Jul 2, 2025
erofs:erofs-snapshotter
Merged
erofs-differ: fix filesystem UUID for tar-converted layers#12046AkihiroSuda merged 1 commit intocontainerd:mainfrom erofs:erofs-snapshotter
AkihiroSuda merged 1 commit intocontainerd:mainfrom
erofs:erofs-snapshotter
Conversation
AkihiroSuda
reviewed
Jul 1, 2025
Derive filesystem UUIDs (`lsblk -o +UUID`) from the OCI layer digests
(although diffIDs are better in principle, but they're unavailable by
differs in advance) rather than generating a random one. This allows
EROFS to uniquely identify each layer using the content-addressable
filesystem UUID.
It can also be used for reproducible builds. To achieve this, configure
`mkfs_options` with `-T0 --mkfs-time` (However, `--mkfs-time` requires
erofs-utils 1.8+; Otherwise, all inode timestamps will be reset w/o it):
``` toml
[plugins."io.containerd.differ.v1.erofs"]
mkfs_options = ["-T0 --mkfs-time"]
```
Fixes: c73c8e5 ("Introduce EROFS differ")
Signed-off-by: Gao Xiang <[email protected]>
AkihiroSuda
approved these changes
Jul 2, 2025
Member
Author
|
/cc @dmcgowan @fuweid @djdongjin @cpuguy83 |
cpuguy83
approved these changes
Jul 2, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
Author
|
/cherry-pick release/2.1 |
|
@hsiangkao: new pull request created: #12058 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
chrishenzie
added
the
cherry-picked/2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive filesystem UUIDs (
lsblk -o +UUID) from the OCI layer digests (although diffIDs are better in principle, but they're unavailable by differs in advance) rather than generating a random one.This allows EROFS to uniquely identify each layer using the content-addressable filesystem UUID.
Note: currently uuid.NewSHA1(uuid.NameSpaceURL, []byte("erofs:blobs/"+desc.Digest)) is used to generate filesystem UUIDs.