Add support for back references in the garbage collector#12025
Merged
AkihiroSuda merged 4 commits intocontainerd:mainfrom Aug 22, 2025
Merged
Add support for back references in the garbage collector#12025AkihiroSuda merged 4 commits intocontainerd:mainfrom
AkihiroSuda merged 4 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Allows an object to create a backreference, allowing objects to be referred to by objects which already exist without updating the labels on the original object. This is useful for ephemeral objects as well as objects with a 1 to many relationship or created after another object. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Merged
AkihiroSuda
reviewed
Jul 9, 2025
| } | ||
| return dgstr.Digest() | ||
| d := dgstr.Digest() | ||
| return digest.NewDigestFromEncoded(d.Algorithm(), fmt.Sprintf("%03d00", i)+d.Encoded()[5:]) |
Member
There was a problem hiding this comment.
this is a test so I think this is just for easy debugging as the i is usually a small integer in the tests, so digests always start 00i00 so it is easy to spot in log output for debugging?
mxpv
approved these changes
Aug 20, 2025
AkihiroSuda
approved these changes
Aug 22, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
dmcgowan
added
impact/changelog
area/storage
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add backreference labels for an object. This allows objects to be referred to by objects which already exist without updating the labels on the original object or referred to by objects which do not yet exist. This is useful for ephemeral objects as well as objects with a 1 to many relationship.
Use cases: