Making it not crash on Windows#120
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Feb 29, 2016
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
nocrashonstartup
branch
from
e271b2c to
3d8e37c
Compare
Author
|
Successful |
Contributor
|
LGTM. |
crosbymichael
added a commit
that referenced
this pull request
Feb 29, 2016
Making it not crash on Windows
jepio
pushed a commit
to jepio/containerd
that referenced
this pull request
Dec 3, 2021
v2: fix issues
jseba
pushed a commit
to jseba/containerd
that referenced
this pull request
Aug 25, 2023
Jenkinsfile: materialize "arches" for easier reading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Changes to make containerd.exe not crash immediately on startup on Windows. It will now at least sit and listen on a TCP socket (localhost:2377). But obviously still non-functional.
Note I have explicitly included
*.exein .gitignore, as opposed to bin\containerd.exe. This is because in order to debug on Windows via gdb64.exe and liteide, the binary appears to need to be in the same directory as main.go. Breakpoints don't trigger if I build into the ..\bin directory.@crosbymichael @mlaventure