Skip to content

Fix multipart fetch issue when the server does not return content length#11992

Merged
estesp merged 1 commit intocontainerd:mainfrom
azr:fix-multipart-fetch-missing-content-len
Jun 19, 2025
Merged

Fix multipart fetch issue when the server does not return content length#11992
estesp merged 1 commit intocontainerd:mainfrom
azr:fix-multipart-fetch-missing-content-len

Conversation

@azr
Copy link
Copy Markdown
Contributor

@azr azr commented Jun 17, 2025 •
edited
Loading

Before: ( mutipart fetching needs to be conf'ed )

ctr i pull public.ecr.aws/mountpoint-s3-csi-driver/aws-mountpoint-s3-csi-driver:v1.14.1
...
application/vnd.docker.distribution.manifest.list.v2+json sha256:e64728220f5cc60477e9dd5415b33a7bb0cc024dbf8fe25eba8397b9f30c3a62
Pulling from OCI Registry (public.ecr.aws/mountpoint-s3-csi-driver/aws-mountpoint-s3-csi-driver:v1.14.1) elapsed: 23.1s  total:   0.0 B  (0.0 B/s)
ERRO[0035] progress stream failed to recv                error="error reading from server: EOF"
ctr: error reading from server: EOF

It is worth noting that when we don't know the size of the file, multipart fetching will be disabled.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Jun 17, 2025
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 17, 2025

Hi @azr. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added area/distribution Image Distribution kind/bug labels Jun 17, 2025
@azr azr force-pushed the fix-multipart-fetch-missing-content-len branch 2 times, most recently from 654ae90 to d059c64 Compare June 17, 2025 09:46
@azr azr force-pushed the fix-multipart-fetch-missing-content-len branch from d059c64 to 1e52cec Compare June 17, 2025 09:54
dmcgowan
dmcgowan reviewed Jun 19, 2025
View reviewed changes
Comment thread core/remotes/docker/fetcher.go Outdated
@azr azr force-pushed the fix-multipart-fetch-missing-content-len branch from 1e52cec to cb53f38 Compare June 19, 2025 15:45
@dmcgowan dmcgowan added the cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch label Jun 19, 2025
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jun 19, 2025

/cherry-pick release/2.1

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 19, 2025

@dmcgowan: once the present PR merges, I will cherry-pick it on top of release/2.1 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dmcgowan dmcgowan changed the title fix when multipart fetching and the server does not return content length Fix multipart fetch issue when the server does not return content length Jun 19, 2025
@dmcgowan dmcgowan mentioned this pull request Jun 19, 2025
Merged
2 tasks
@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Jun 19, 2025
@estesp estesp added this pull request to the merge queue Jun 19, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 19, 2025
@estesp estesp added this pull request to the merge queue Jun 19, 2025
Merged via the queue into containerd:main with commit 5e1f8ff Jun 19, 2025
122 of 126 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jun 19, 2025
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 19, 2025

@dmcgowan: new pull request created: #12003

Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 19, 2025
Merged
@azr azr mentioned this pull request Jul 1, 2025
Closed
@austinvazquez austinvazquez added cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch and removed cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees

No one assigned

Labels

area/distribution Image Distribution cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch kind/bug needs-ok-to-test size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@azr @k8s-ci-robot @dmcgowan @k8s-infra-cherrypick-robot @cpuguy83 @estesp @austinvazquez