Skip to content

[release/2.1] Fix registry errors with transfer service#11979

Merged
dmcgowan merged 2 commits intocontainerd:release/2.1from
k8s-infra-cherrypick-robot:cherry-pick-11976-to-release/2.1
Jun 19, 2025
Merged

[release/2.1] Fix registry errors with transfer service#11979
dmcgowan merged 2 commits intocontainerd:release/2.1from
k8s-infra-cherrypick-robot:cherry-pick-11976-to-release/2.1

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 12, 2025

This is an automated cherry-pick of #11976

/assign dmcgowan

dmcgowan added 2 commits June 12, 2025 14:42
@dmcgowan
Decode grpc errors in the transfer client proxy
7c18133 
Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan
Register remote errors for clients to access registry errors
f6d9263 
Currently the error is not encoded and only the error message can be
retrieved on the client. With this change, clients can access the
unexpected error type even over grpc.

Signed-off-by: Derek McGowan <[email protected]>
@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Jun 12, 2025
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 12, 2025
Merged
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 12, 2025

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/distribution Image Distribution label Jun 12, 2025
austinvazquez
austinvazquez approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Jun 12, 2025
@austinvazquez
Copy link
Copy Markdown
Member

austinvazquez commented Jun 13, 2025

Rerunning Windows integration tests due to 503s coming back from MCR.

@dmcgowan dmcgowan merged commit 64794de into containerd:release/2.1 Jun 19, 2025
224 of 234 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jun 19, 2025
@dmcgowan dmcgowan mentioned this pull request Jun 19, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@estesp estesp estesp approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

@dmcgowan dmcgowan

Labels

area/distribution Image Distribution impact/changelog ok-to-test size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @austinvazquez @dims @estesp @dmcgowan