erofs-snapshotter: fix to work with wrapped errors#11934
Merged
fuweid merged 1 commit intocontainerd:mainfrom Jun 4, 2025
erofs:erofs-snapshotter
Merged
erofs-snapshotter: fix to work with wrapped errors#11934fuweid merged 1 commit intocontainerd:mainfrom erofs:erofs-snapshotter
fuweid merged 1 commit intocontainerd:mainfrom
erofs:erofs-snapshotter
Conversation
Member
Author
Member
Author
|
Since #11861 is already cherry-picked into v2.1, this fix should be backported to v2.1 too. |
thaJeztah
added
the
cherry-pick/2.1.x
Contributor
|
Tested this fix, and I do not see the error anymore. Thank you! :) |
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: #11861 Signed-off-by: Gao Xiang <[email protected]>
fuweid
approved these changes
Jun 4, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
dmcgowan
approved these changes
Jun 4, 2025
djdongjin
approved these changes
Jun 4, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
Author
|
/cherry-pick release/2.1 |
|
@hsiangkao: new pull request created: #11935 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dmcgowan
added
cherry-picked/2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Fix it now.
Thanks @aadhar-agarwal for reporting.