Update transfer supported platforms logic#11927
Conversation
Allow selection of a non-default snapshotter when no unpack snapshotter is specified. Add more logging to help figure out why an unpack configuration is not used. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
added
cherry-pick/2.1.x
| log.G(ctx).WithFields(log.Fields{ | ||
| "platform": platforms.FormatAll(uc.Platform), | ||
| "snapshotter": uc.Snapshotter, | ||
| }).Info("Found unpack with matching snapshotter but platform does not match") |
There was a problem hiding this comment.
Is this something the customer should be warned about (could cause an issue)?
There was a problem hiding this comment.
Its not necessarily an error though. The caller will get an error is no platform ends up being matched and this may be helpful as to the hint why. Currently just a generic error is seen without anything useful in the logs to understand why.
There was a problem hiding this comment.
See #11606 as an example. There may be a follow-up after this change to correct for more cases or another bug which is causing that error.
| } { | ||
| t.Run(testCase.Name, func(t *testing.T) { | ||
| m, sp := getSupportedPlatform(testCase.UnpackConfig, testCase.SupportedPlatforms) | ||
| m, sp := getSupportedPlatform(t.Context(), testCase.UnpackConfig, testCase.SupportedPlatforms) |
There was a problem hiding this comment.
Oh TIL, t.Context() that's nice.
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Merge on Green
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
|
/cherry-pick release/2.1 |
|
@dmcgowan: new pull request created: #11999 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dmcgowan
added
cherry-picked/2.1.x
7 participants
Allow selection of a non-default snapshotter when no unpack snapshotter is specified.
Add more logging to help figure out why an unpack configuration is not used.