Tar unpack progress through transfer service #11921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
changed the title
AkihiroSuda
reviewed
May 31, 2025
| "github.com/containerd/platforms" | ||
| "github.com/opencontainers/image-spec/identity" | ||
| ocispec "github.com/opencontainers/image-spec/specs-go/v1" | ||
| "github.com/urfave/cli/v2" |
Member
There was a problem hiding this comment.
This linter changes should be probably a separate PR?
AkihiroSuda
reviewed
May 31, 2025
cmd/ctr/commands/images/pull.go
Outdated
| roots = []*progressNode{} | ||
| progress transfer.ProgressFunc | ||
| pc = make(chan transfer.Progress, 1) | ||
| pc = make(chan transfer.Progress, 5) |
Member
There was a problem hiding this comment.
This number seems to need an explanation
Member
Author
There was a problem hiding this comment.
Added, although this is still kind of a bandaid solution. Right now the progress drain is a bit racy and we could probably add a better solution, especially if we could just rely on some indicator in the progress stream that the end has been reached (with a timeout accounting for it not being reached).
AkihiroSuda
approved these changes
Sep 8, 2025
Member
|
Probably this should be rebased to run the tests with the latest main |
djdongjin
approved these changes
Sep 10, 2025
core/diff/apply/apply.go
Outdated
| return pr.c.Close() | ||
| } | ||
|
|
||
| type closeReader struct { |
Member
There was a problem hiding this comment.
nit: should we call it readCloser to more align with go's ReadCloser?
github-project-automation
bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
Allows the apply process to return progress on the tar apply operation. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
unpack-progress
branch
from
a6bd023 to
479cf42
Compare
AkihiroSuda
approved these changes
Sep 17, 2025
github-project-automation
bot
moved this from Review In Progress
to Done
in Pull Request Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unpack to transfer service.
See https://asciinema.org/a/6bJRKKKuqkAVV51GjN8SBSeYu
A few notes...