Fix transfer differ selection#11915
Merged
fuweid merged 3 commits intocontainerd:mainfrom Jun 4, 2025
Merged
Conversation
dmcgowan
added
the
cherry-pick/2.1.x
dmcgowan
force-pushed
the
fix-transfer-differ-selection
branch
from
c2d3640 to
a612a28
Compare
AkihiroSuda
approved these changes
May 31, 2025
henry118
approved these changes
Jun 3, 2025
Signed-off-by: Derek McGowan <[email protected]>
Currently the error details are not included in the output error and there is no log. One of the reasons a the transferer was skipped could be do to a specific component which is not implemented (such as trying to use erofs differ) or unsupported image (pulling schema1). This information is useful to find a bad configuration. Signed-off-by: Derek McGowan <[email protected]>
Currently the erofs differ will be chosen and cause pulls to fail with not implemented errors. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
fix-transfer-differ-selection
branch
from
a612a28 to
4f7c69a
Compare
estesp
approved these changes
Jun 3, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
fuweid
approved these changes
Jun 4, 2025
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
Author
|
/cherry-pick release/2.1 |
|
@dmcgowan: new pull request created: #11936 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dmcgowan
added
cherry-picked/2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update differ selection in transfer service to prefer default
Currently the erofs differ will be chosen and cause pulls to fail with not implemented errors.
We should also consider whether the differ should have an export configuration which limits which snapshotters it should be used with
Add debug log when transfer returns not implemented
Currently the error details are not included in the output error and there is no log. One of the reasons a the transferer was skipped could be do to a specific component which is not implemented (such as trying to use erofs differ) or unsupported image (pulling schema1). This information is useful to find a bad configuration.
We could also consider returning this error detail to the caller, it could be relevant in in the schema 1 case to indicate the image is not supported.
Add more error details when unpack fails to extract