Enable DuplicationSuppressor in transfer service#11914
Merged
estesp merged 1 commit intocontainerd:mainfrom Jun 3, 2025
Merged
Enable DuplicationSuppressor in transfer service#11914estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Henry Wang <[email protected]>
dmcgowan
approved these changes
Jun 2, 2025
dmcgowan
added
the
cherry-pick/2.1.x
estesp
approved these changes
Jun 3, 2025
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
Member
Author
|
/cherry-pick release/2.1 |
|
@henry118: new pull request created: #11932 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dmcgowan
added
cherry-picked/2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables
DuplicationSuppressorin transfer service.#6702 introduced "DuplicationSuppressor" capability and enabled it by default in CRI. But the object value in transfer service config remained nil and never been effective.
Given CRI defaults to transfer service in 2.1, I think we should enable this capability to match the "local pull" behavior.
I did not introduce a new config in transfer service to toggle this capability because I don't see a use case where such behavior isn't desirable. But I'm also open to make it configurable if it's suggested otherwise.