client:improve mount error message#11861
Conversation
|
Hi @ningmingxiao. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ningmingxiao
force-pushed
the
mount_err_detail
branch
3 times, most recently
from
e71f2d1 to
c44cf3e
Compare
ningmingxiao
force-pushed
the
mount_err_detail
branch
from
c44cf3e to
e71f2d1
Compare
Signed-off-by: ningmingxiao <[email protected]>
ningmingxiao
force-pushed
the
mount_err_detail
branch
from
e71f2d1 to
fb6dd2c
Compare
|
can this pr be merged? @samuelkarp @dmcgowan @AkihiroSuda it's easy to review. |
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
|
/cherry-pick release/2.1 |
|
@AkihiroSuda: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
|
@AkihiroSuda: new pull request created: #11884 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
Commit fb6dd2c ("client:improve mount error message") changed the return value into a wraped error message, which causes the ENOTBLK check doesn't work. Reported-by: Aadhar Agarwal <[email protected]> Fixes: containerd#11861 Signed-off-by: Gao Xiang <[email protected]>
chrishenzie
added
the
cherry-picked/2.1.x
7 participants
if use containerd api in container to create container will return error:
It is misleading because /tmp/containerd-mount530130800 exists.
ref:#11849
after this commit