Skip to content

Update fetcher errors to include full registry error#11669

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan:fix-fetcher-error-encoding
Jun 12, 2025
Merged

Update fetcher errors to include full registry error#11669
dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan:fix-fetcher-error-encoding

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Apr 9, 2025 •
edited
Loading

Currently the registry error does not include details or allow the caller access to the original error body.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Apr 9, 2025
@dmcgowan
Update fetcher errors to include full registry error
af068ff 
Currently the registry error does not include details or allow the
caller access to the original error body.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the fix-fetcher-error-encoding branch from 513a009 to af068ff Compare June 12, 2025 01:52
@dmcgowan dmcgowan marked this pull request as ready for review June 12, 2025 01:52
@dmcgowan dmcgowan added the cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch label Jun 12, 2025
@dmcgowan
Copy link
Copy Markdown
Member Author

dmcgowan commented Jun 12, 2025

Updated and should be ready for review. Marked as cherry-pick for 2.1 since there are currently cases in which the client cannot fully access the registry error. This also makes the error result more consistent across resolve/fetch/push.

@dmcgowan dmcgowan enabled auto-merge June 12, 2025 01:55
austinvazquez
austinvazquez approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the thumbs up on this. Some registries are having a bad time today and causing the CI issues.

@dmcgowan dmcgowan added this pull request to the merge queue Jun 12, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Jun 12, 2025
Merged via the queue into containerd:main with commit 2af24b5 Jun 12, 2025
124 of 128 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jun 12, 2025
@dmcgowan
Copy link
Copy Markdown
Member Author

dmcgowan commented Jun 18, 2025

/cherry-pick release/2.1

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 18, 2025

@dmcgowan: new pull request created: #11997

Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 18, 2025
Merged
@dmcgowan dmcgowan added cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch and removed cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

area/distribution Image Distribution cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch kind/enhancement size/M

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmcgowan @k8s-ci-robot @k8s-infra-cherrypick-robot @estesp @austinvazquez