Skip to content

[release/1.7] cri:fix lost container exit events if they arrive before info is cached#11634

Merged
samuelkarp merged 1 commit into
containerd:release/1.7from
ningmingxiao:v1.7_fix_event
Jun 30, 2026
Merged

[release/1.7] cri:fix lost container exit events if they arrive before info is cached#11634
samuelkarp merged 1 commit into
containerd:release/1.7from
ningmingxiao:v1.7_fix_event

Conversation

@ningmingxiao

@ningmingxiao ningmingxiao commented Apr 1, 2025 •
edited by chrishenzie
Loading

Copy link
Copy Markdown
Contributor

cherry-pick from ead5c1e

Fix lost container exit events when events arrive before container info is cached

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Apr 1, 2025
@k8s-ci-robot

k8s-ci-robot commented Apr 1, 2025

Copy link
Copy Markdown

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added area/cri Container Runtime Interface (CRI) kind/bug labels Apr 1, 2025
@ningmingxiao
ningmingxiao force-pushed the v1.7_fix_event branch 2 times, most recently from fa42c73 to 5871c2b Compare April 1, 2025 04:48
@ningmingxiao ningmingxiao mentioned this pull request Dec 1, 2025
Open
@ningmingxiao ningmingxiao mentioned this pull request Mar 17, 2026
Open
@samuelkarp

samuelkarp commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Mind updating the cherry-pick with -x so the original commit is also tracked? I understand this was partly done by hand (to deal with the sbserver split) but it'd still be helpful to track that in the commit message.

Edit: LGTM once the commit message is updated.

@samuelkarp
samuelkarp self-requested a review March 28, 2026 00:00
@samuelkarp samuelkarp self-assigned this Mar 28, 2026
@samuelkarp

samuelkarp commented Mar 30, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@samuelkarp
samuelkarp requested a review from chrishenzie March 30, 2026 22:27
@ningmingxiao

ningmingxiao commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

done thanks can you review my another pr #12846 we want to use this new api @samuelkarp

@samuelkarp

samuelkarp commented Mar 31, 2026

Copy link
Copy Markdown
Member

/retest

@samuelkarp samuelkarp changed the title cherry-pick 1.7 cri:fix lost container exit events if they arrive before info is cached [release/1.7] cri:fix lost container exit events if they arrive before info is cached Apr 7, 2026
@samuelkarp

samuelkarp commented Apr 7, 2026

Copy link
Copy Markdown
Member

Cherry-pick of #11579 (just mentioning it to have proper cross-links).

@ningmingxiao ningmingxiao mentioned this pull request Apr 14, 2026
Merged
@chrishenzie

chrishenzie commented May 18, 2026

Copy link
Copy Markdown
Member

Is anything blocking merging this? The 2.0 cherry-pick already landed, so it would be good to land here as well since 1.7 is still in support

@samuelkarp

samuelkarp commented May 18, 2026

Copy link
Copy Markdown
Member

I don't think we've done a 2.0 with #11633 yet, and I'd like to have that out first to get at least a little soak time on it.

@samuelkarp

samuelkarp commented Jun 26, 2026

Copy link
Copy Markdown
Member

@ningmingxiao Do you mind rebasing this one?

@ningmingxiao
cri:fix lost container exit events if they arrive before info is cached
2fe076e 
Signed-off-by: ningmingxiao <[email protected]>
(cherry picked from commit ead5c1e)
Signed-off-by: ningmingxiao <[email protected]>
@ningmingxiao

ningmingxiao commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

@ningmingxiao Do you mind rebasing this one?

done thanks

@samuelkarp samuelkarp moved this from Needs Triage to Needs Reviewers in Pull Request Review Jun 29, 2026
@github-project-automation github-project-automation Bot moved this from Needs Reviewers to Review In Progress in Pull Request Review Jun 30, 2026
@samuelkarp
samuelkarp merged commit 7df7d64 into containerd:release/1.7 Jun 30, 2026
91 of 92 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Jun 30, 2026
@ningmingxiao
ningmingxiao deleted the v1.7_fix_event branch June 30, 2026 23:46
@chrishenzie chrishenzie mentioned this pull request Jul 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes
@chrishenzie chrishenzie chrishenzie approved these changes

Assignees

@samuelkarp samuelkarp

Labels

area/cri Container Runtime Interface (CRI) impact/changelog kind/bug ok-to-test size/M

Projects

Pull Request Review
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ningmingxiao @k8s-ci-robot @samuelkarp @chrishenzie