Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config:fix config migrate lost timeout config #11532

Merged
merged 1 commit into from
Mar 14, 2025
Merged

config:fix config migrate lost timeout config #11532

merged 1 commit into from
Mar 14, 2025

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Mar 12, 2025 •
edited
Loading

@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ningmingxiao ningmingxiao mentioned this pull request Mar 12, 2025
Open
@ningmingxiao ningmingxiao force-pushed the fix_migrate branch 2 times, most recently from db89697 to 5d9ec94 Compare March 12, 2025 12:14
@ningmingxiao ningmingxiao mentioned this pull request Mar 12, 2025
Merged
@ningmingxiao ningmingxiao changed the title config:fix migrate lost timeout config config:fix config migrate lost timeout config Mar 12, 2025
djdongjin
djdongjin reviewed Mar 12, 2025
View reviewed changes
@djdongjin
Copy link
Member

/ok-to-test

@djdongjin djdongjin requested a review from dmcgowan March 12, 2025 13:31
djdongjin
djdongjin approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Mar 14, 2025 •
edited
Loading

ping @samuelkarp

@ningmingxiao ningmingxiao mentioned this pull request Mar 14, 2025
Merged
@dmcgowan dmcgowan added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@dmcgowan dmcgowan added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@estesp estesp added this pull request to the merge queue Mar 14, 2025
Merged via the queue into containerd:main with commit f4f0b9b Mar 14, 2025
58 checks passed
@ningmingxiao ningmingxiao mentioned this pull request Mar 14, 2025
Open
@ningmingxiao ningmingxiao deleted the fix_migrate branch March 14, 2025 16:17
@dmcgowan dmcgowan added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch ok-to-test size/S
Projects
Pull Request Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ningmingxiao @k8s-ci-robot @djdongjin @dmcgowan @estesp