Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/2.0] Fix incorrect runtime name being passed to NRI #11529

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[release/2.0] Fix incorrect runtime name being passed to NRI #11529

merged 1 commit into from
Mar 13, 2025

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao
add name in package version
4f03705 
Signed-off-by: ningmingxiao <[email protected]>
@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the area/nri Node Resource Interface (NRI) label Mar 11, 2025
@djdongjin djdongjin changed the title add name in package version [release/2.0] add name in package version Mar 11, 2025
@dmcgowan dmcgowan changed the title [release/2.0] add name in package version [release/2.0] Fix incorrect runtime name being passed to NRI Mar 13, 2025
@dmcgowan dmcgowan merged commit 76db058 into containerd:release/2.0 Mar 13, 2025
56 checks passed
@ningmingxiao ningmingxiao deleted the v2.0_fix branch March 13, 2025 16:11
@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Mar 13, 2025 •
edited
Loading

can you review pr 11532 thank you

@dmcgowan dmcgowan mentioned this pull request Mar 14, 2025
Merged
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@klihub klihub klihub approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
area/nri Node Resource Interface (NRI) impact/changelog needs-ok-to-test size/XS
Projects
Pull Request Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ningmingxiao @k8s-ci-robot @dmcgowan @klihub @AkihiroSuda @djdongjin