Skip to content

add name in package version#11518

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
ningmingxiao:add_name
Mar 10, 2025
Merged

add name in package version#11518
dmcgowan merged 1 commit intocontainerd:mainfrom
ningmingxiao:add_name

Conversation

@ningmingxiao
Copy link
Copy Markdown
Contributor

@ningmingxiao ningmingxiao commented Mar 10, 2025 •
edited
Loading

fix:#11485

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Mar 10, 2025
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 10, 2025

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/nri Node Resource Interface (NRI) label Mar 10, 2025
@ningmingxiao ningmingxiao mentioned this pull request Mar 10, 2025
Closed
@ningmingxiao
add name in package version
405a952 
Signed-off-by: ningmingxiao <[email protected]>
rogowski-piotr
rogowski-piotr approved these changes Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown

@rogowski-piotr rogowski-piotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Should help in my opinion ;)

@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 10, 2025
@dmcgowan dmcgowan added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Mar 10, 2025
@dmcgowan dmcgowan added this pull request to the merge queue Mar 10, 2025
Merged via the queue into containerd:main with commit 07dd4cc Mar 10, 2025
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Mar 10, 2025
@ningmingxiao ningmingxiao deleted the add_name branch March 10, 2025 15:54
@austinvazquez austinvazquez mentioned this pull request May 12, 2025
Merged
@austinvazquez austinvazquez added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@laurazard laurazard laurazard approved these changes

+1 more reviewer

@rogowski-piotr rogowski-piotr rogowski-piotr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/nri Node Resource Interface (NRI) cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch needs-ok-to-test size/XS

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ningmingxiao @k8s-ci-robot @dmcgowan @cpuguy83 @rogowski-piotr @laurazard @austinvazquez