Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] build(deps): bump containerd/project-checks from 1.1.0 to 1.2.1 #11494

Closed
wants to merge 1 commit into from
Closed

[release/1.7] build(deps): bump containerd/project-checks from 1.1.0 to 1.2.1 #11494

wants to merge 1 commit into from

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Mar 6, 2025

updating project-checks as per #11474

@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Mar 6, 2025
@k8s-ci-robot
Copy link

@akhilerm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-node-e2e-1-7 c1bfb8e link true /test pull-containerd-node-e2e-1-7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@akhilerm akhilerm changed the title [release/1.7] update containerd/project-checks to 1.2.1 [release/1.7] build(deps): bump containerd/project-checks from 1.1.0 to 1.2.1 Mar 6, 2025
@akhilerm
Copy link
Member Author

akhilerm commented Mar 6, 2025

The failure in pull-containerd-node-e2e-1-7 can be ignored for now as the fix PR requires the project-checks to be updated.

For the failure in project checks is due to license error in hashicorp/errwrap

@djdongjin
Copy link
Member

For the failure in project checks is due to license error in hashicorp/errwrap

Do you know why it started to fail now? Is it because project checks started to track this recently?

@akhilerm
Copy link
Member Author

akhilerm commented Mar 6, 2025

Do you know why it started to fail now? Is it because project checks started to track this recently?

From the diff here containerd/project-checks@v1.1.0...v1.2.1, it was introduced only from v1.2.0.

Any thoughts on what should we do about this? I am sure that we cannot have MPL license into the ignore list.
cc: @AkihiroSuda

@djdongjin
Copy link
Member

@akhilerm I can make a PR today to remove that deps in 1.7 and 1.6.

I made a similar one a while ago (#8992), but that one seems not included in 1.7. Tried cherrypick but there are some conflict.

@akhilerm
Copy link
Member Author

akhilerm commented Mar 6, 2025

Great. Thank you;

This was referenced Mar 6, 2025
Merged
Merged
@austinvazquez
Copy link
Member

Closing for #11499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code size/XS
Projects
Pull Request Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhilerm @k8s-ci-robot @djdongjin @austinvazquez