Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.{mod,sum}: bump CDI deps to v.0.8.1. #11449

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

klihub
Copy link
Member

@klihub klihub commented Feb 27, 2025

Update CDI dependency to v0.8.1. That pulls in a fix for a SIGSEGV/panic, which in principle could be triggered if we're out of file descriptors while we're instantiating the CDI cache.

@dosubot dosubot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 27, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AkihiroSuda AkihiroSuda added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 27, 2025
@thaJeztah
Copy link
Member

Looks like this needs a rebase, @klihub

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the fixes/main/cdi-emfile-sigsegv branch from c52967f to 22d568f Compare February 27, 2025 16:10
@fuweid fuweid added this pull request to the merge queue Feb 27, 2025
Merged via the queue into containerd:main with commit 4d36c2d Feb 27, 2025
58 checks passed
@klihub klihub deleted the fixes/main/cdi-emfile-sigsegv branch February 28, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code size/S
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants