Skip to content

[release/2.0] go.{mod,sum}: bump CDI deps to v.0.8.1.#11430

Merged
AkihiroSuda merged 1 commit intocontainerd:release/2.0from
klihub:fixes/release/2.0.x/cdi-emfile-sigsegv
Feb 27, 2025
Merged

[release/2.0] go.{mod,sum}: bump CDI deps to v.0.8.1.#11430
AkihiroSuda merged 1 commit intocontainerd:release/2.0from
klihub:fixes/release/2.0.x/cdi-emfile-sigsegv

Conversation

@klihub
Copy link
Copy Markdown
Member

@klihub klihub commented Feb 25, 2025

Update CDI dependency to v0.8.1. That pulls in a fix for a SIGSEGV/panic, which in principle could be triggered if we're out of file descriptors while we're instantiating the CDI cache.

@dosubot dosubot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 25, 2025
Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the fixes/release/2.0.x/cdi-emfile-sigsegv branch from 9acb140 to 92ae295 Compare February 25, 2025 07:40
@thaJeztah
Copy link
Copy Markdown
Member

Could you open a PR against main as well? Otherwise we may regress if a new release is created from main and it doesn't have this update.

@klihub
Copy link
Copy Markdown
Member Author

klihub commented Feb 27, 2025

Update CDI dependency to v0.8.1. That pulls in a fix for a SIGSEGV/panic, which in principle could be triggered if we're out of file descriptors while we're instantiating the CDI cache.

Opened #11449. Sorry for the delay. I was meant to do it right after 2.0.x, but got caught up and then sidetracked by something else.

@thaJeztah
Copy link
Copy Markdown
Member

Thanks, and no worries! (Sorry for being pedantic; just have had the experience that we had a contributor opening a fix against a release branch, and we didn't notice, then ended up with a regression in the release after 🙈); GitHub makes it really easy to miss what branch a PR was opened against (we ended up with a rather hacky way to invalidate PRs if they don't mention the release branch in the title for that reason)

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review Feb 27, 2025
@AkihiroSuda AkihiroSuda merged commit 67bb32a into containerd:release/2.0 Feb 27, 2025
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Feb 27, 2025
@klihub
Copy link
Copy Markdown
Member Author

klihub commented Feb 28, 2025

Thanks, and no worries! (Sorry for being pedantic; just have had the experience that we had a contributor opening a fix against a release branch, and we didn't notice, then ended up with a regression in the release after 🙈); GitHub makes it really easy to miss what branch a PR was opened against (we ended up with a rather hacky way to invalidate PRs if they don't mention the release branch in the title for that reason)

@thaJeztah No prob and no offense taken whatsoever. I agree that it is better to call out/remind in these cases just to be sure. Some folks get easily distracted and then forget things. And I am definitely one of those nowadays.

@klihub klihub deleted the fixes/release/2.0.x/cdi-emfile-sigsegv branch February 28, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants