-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/2.0] go.{mod,sum}: bump CDI deps to v.0.8.1. #11430
[release/2.0] go.{mod,sum}: bump CDI deps to v.0.8.1. #11430
Conversation
Signed-off-by: Krisztian Litkey <[email protected]>
9acb140
to
92ae295
Compare
Could you open a PR against |
Opened #11449. Sorry for the delay. I was meant to do it right after 2.0.x, but got caught up and then sidetracked by something else. |
Thanks, and no worries! (Sorry for being pedantic; just have had the experience that we had a contributor opening a fix against a release branch, and we didn't notice, then ended up with a regression in the release after 🙈); GitHub makes it really easy to miss what branch a PR was opened against (we ended up with a rather hacky way to invalidate PRs if they don't mention the release branch in the title for that reason) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thaJeztah No prob and no offense taken whatsoever. I agree that it is better to call out/remind in these cases just to be sure. Some folks get easily distracted and then forget things. And I am definitely one of those nowadays. |
Update CDI dependency to v0.8.1. That pulls in a fix for a SIGSEGV/panic, which in principle could be triggered if we're out of file descriptors while we're instantiating the CDI cache.