[release/1.6] update build to go1.23.7, test go1.24.1 #11421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
area/toolchain
akhilerm
force-pushed
the
1.6-update-go1.24
branch
from
9cf83e9 to
977b99e
Compare
djdongjin
reviewed
Mar 7, 2025
.github/workflows/ci.yml
Outdated
| @@ -218,7 +218,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-20.04, ubuntu-24.04-arm, macos-13, windows-2019, windows-2022] | |||
| go-version: ["1.22.10", "1.23.4"] | |||
| go-version: ["1.23.6", "1.24.0"] | |||
There was a problem hiding this comment.
there is 1.24.1 and 1.23.7 now. https://go.dev/doc/devel/release#go1.24.minor
should we just use the latest direclty?
There was a problem hiding this comment.
That change is not yet present on the main and release branches.
I will make that bump on those(main.2.0,1.7) branches and then update this PR.
- go1.23.7 (released 2025-03-04) includes security fixes to the net/http package, as well as bug fixes to cgo, the compiler, and the reflect, runtime, and syscall packages. See the Go 1.23.7 milestone on our issue tracker for details - go1.24.1 (released 2025-03-04) includes security fixes to the net/http package, as well as bug fixes to cgo, the compiler, the go command, and the reflect, runtime, and syscall packages. See the Go 1.24.1 milestone on our issue tracker for details. Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
1.6-update-go1.24
branch
from
977b99e to
820e81a
Compare
akhilerm
changed the title
|
@akhilerm for the golangci-lint failure, you probably need this fix https://github.com/containerd/containerd/pull/11400/files |
akhilerm
force-pushed
the
1.6-update-go1.24
branch
2 times, most recently
from
5b1ca10 to
75eefca
Compare
Signed-off-by: Kohei Tokunaga <[email protected]> Signed-off-by: Akhil Mohan <[email protected]> Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Jin Dong <[email protected]> (cherry picked from commit 480e103) Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
1.6-update-go1.24
branch
from
75eefca to
b67a35b
Compare
djdongjin
approved these changes
Mar 10, 2025
estesp
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.23.7 (released 2025-03-04) includes security fixes to the net/http
package, as well as bug fixes to cgo, the compiler, and the reflect,
runtime, and syscall packages. See the Go 1.23.7 milestone on our issue
tracker for details
go1.24.1 (released 2025-03-04) includes security fixes to the net/http
package, as well as bug fixes to cgo, the compiler, the go command, and
the reflect, runtime, and syscall packages. See the Go 1.24.1 milestone
on our issue tracker for details.