Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/2.0] build(deps): bump actions/cache from 4.1.2 to 4.2.0 #11404

Closed
wants to merge 1 commit into from
Closed

[release/2.0] build(deps): bump actions/cache from 4.1.2 to 4.2.0 #11404

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #11124

/assign djdongjin

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2025
Merged
@k8s-ci-robot
Copy link

@k8s-infra-cherrypick-robot: GitHub didn't allow me to assign the following users: djdongjin.

Note that only containerd members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #11124

/assign djdongjin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 18, 2025
@djdongjin djdongjin mentioned this pull request Feb 18, 2025
Merged
@samuelkarp
Copy link
Member

FAIL - does not have a valid DCO

But how did this pass in main?

@samuelkarp
Copy link
Member

Somehow the cherrypick bot lost this part of the commit message??

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

@djdongjin
Copy link
Member

Somehow the cherrypick bot lost this part of the commit message??

It's likely some issue with the bot (other repos have similar issues, e.g., kubernetes/ingress-nginx@c39e75b v.s. kubernetes/ingress-nginx@481de71)

I just created a manual cherrypick here #11405

@djdongjin djdongjin mentioned this pull request Feb 18, 2025
Merged
@estesp
Copy link
Member

estesp commented Feb 18, 2025

already replaced by a non-cherry-picked version in #11405

@estesp estesp closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code needs-ok-to-test size/XS
Projects
Pull Request Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @samuelkarp @djdongjin @estesp @mxpv