Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.0] Revert "Add timestamp to PodSandboxStatusResponse for kubernetes Evented PLEG" #11403

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #11323

/assign djdongjin

…ted PLEG"

This reverts commit b529072.

Signed-off-by: Chris Henzie <[email protected]>
@k8s-ci-robot
Copy link

@k8s-infra-cherrypick-robot: GitHub didn't allow me to assign the following users: djdongjin.

Note that only containerd members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #11323

/assign djdongjin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djdongjin
Copy link
Member

/retest

1 similar comment
@samuelkarp
Copy link
Member

/retest

@djdongjin
Copy link
Member

The CI error is a bit wired. It says the cache action (v1/v2) is deprecated and recommends v3/v4.

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: 6849a6489940f00c2f30c0fb92c6274307ccb58a. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

But release/2.0 is already using v4 (4.1.2) 🤔

actions/cache@6849a64

@djdongjin
Copy link
Member

ah 4.1.2 is indeed deprecated, (4.2.0 is the supported one)

https://github.com/actions/cache#:~:text=If%20you%20are%20using%20pinned%20SHAs%2C%20please%20use%20the%20SHAs%20of%20versions%20v4.2.0%20or%20v3.4.0

If you are using pinned SHAs, please use the SHAs of versions v4.2.0 or v3.4.0

trying cherrypick #11124 to 2.0 branch, but saw failures in the created PR #11404 (review). If the auto PR doesn't go through, I will manually cherrypick

@djdongjin
Copy link
Member

/retest

@djdongjin
Copy link
Member

/test pull-containerd-k8s-e2e-ec2

2 similar comments
@djdongjin
Copy link
Member

/test pull-containerd-k8s-e2e-ec2

@djdongjin
Copy link
Member

/test pull-containerd-k8s-e2e-ec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants