Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri: introduce io.containerd.timeout.cri.defercleanup setting #11380

Merged
merged 1 commit into from
Mar 21, 2025
Merged

cri: introduce io.containerd.timeout.cri.defercleanup setting #11380

merged 1 commit into from
Mar 21, 2025

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Feb 12, 2025 •
edited by fuweid
Loading

Allows admin to configure io.containerd.timeout.cri.defercleanup timeout

@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the area/cri Container Runtime Interface (CRI) label Feb 12, 2025
@ningmingxiao ningmingxiao changed the title increase deferCleanupTimeout 1min to 5min increase deferCleanupTimeout 1min to 5min to fix exec fifo leak Feb 12, 2025
@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Feb 12, 2025 •
edited
Loading

@fuweid @mxpv @AkihiroSuda can you review this pr thank you.

@ningmingxiao ningmingxiao mentioned this pull request Feb 18, 2025
Closed
mxpv
mxpv reviewed Feb 20, 2025
View reviewed changes
@ningmingxiao ningmingxiao changed the title increase deferCleanupTimeout 1min to 5min to fix exec fifo leak support to set cleanUpTimeout to decrease ctx timeout Feb 21, 2025
@ningmingxiao ningmingxiao force-pushed the increase_time_out branch 3 times, most recently from 02ca999 to b10c9da Compare February 21, 2025 08:42
@ningmingxiao ningmingxiao changed the title support to set cleanUpTimeout to decrease ctx timeout support to set defer cleanup timeout to decrease ctx timeout Feb 21, 2025
@ningmingxiao
Copy link
Contributor Author

done, cc @mxpv @fuweid

fuweid
fuweid reviewed Feb 25, 2025
View reviewed changes
fuweid
fuweid reviewed Feb 25, 2025
View reviewed changes
fuweid
fuweid reviewed Feb 25, 2025
View reviewed changes
@fuweid fuweid changed the title support to set defer cleanup timeout to decrease ctx timeout cri: introduce io.containerd.timeout.cri.defercleanup setting Feb 25, 2025
fuweid
fuweid reviewed Feb 25, 2025
View reviewed changes
@ningmingxiao ningmingxiao force-pushed the increase_time_out branch 2 times, most recently from 8808cd6 to 5dcc200 Compare February 25, 2025 15:31
@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Mar 10, 2025 •
edited
Loading

@fuweid @mxpv @cpuguy83 @laurazard @dmcgowan can this pr be merged?

@fuweid fuweid added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@ningmingxiao ningmingxiao mentioned this pull request Mar 12, 2025
Open
@ningmingxiao ningmingxiao mentioned this pull request Mar 14, 2025
Merged
@k8s-ci-robot
Copy link

@ningmingxiao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ningmingxiao
Copy link
Contributor Author

sine this pr is merged (#11532) ci won't fail
this pr can be merged @estesp

mikebrow
mikebrow reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making this configurable some nits..

@ningmingxiao
Copy link
Contributor Author

ping @mikebrow can this pr be merged ?

mikebrow
mikebrow approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow added this pull request to the merge queue Mar 21, 2025
Merged via the queue into containerd:main with commit 8237c49 Mar 21, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdongjin djdongjin djdongjin left review comments

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@mxpv mxpv mxpv approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
area/cri Container Runtime Interface (CRI) needs-ok-to-test size/S
Projects
Pull Request Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ningmingxiao @k8s-ci-robot @cpuguy83 @mxpv @mikebrow @fuweid @djdongjin